Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17][Ops] Update babel to 7.21 #161080

Closed
wants to merge 8 commits into from
Closed

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Jul 3, 2023

Summary

Updates babel to 7.21+, as it's on other open branches.

Closes #160010

Checklist

Delete any items that are not applicable to this PR.

@delanni delanni added chore release_note:skip Skip the PR/issue when compiling release notes v7.17.12 backport:skip This commit does not require backporting Team:Operations Team label for Operations Team labels Jul 3, 2023
@delanni delanni force-pushed the update-babel-7.21 branch from 411f884 to 52e02e8 Compare July 3, 2023 12:14
@delanni
Copy link
Contributor Author

delanni commented Jul 4, 2023

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments about matching deps with main

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
"@babel/eslint-parser": "^7.16.3",
"@babel/eslint-plugin": "^7.14.5",
"@babel/generator": "^7.16.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have we removed @babel/generator into a prod dependency? I dont think it is one. In addition to that consider update to version ^7.21.1 to match main

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It got a warning from one of the tasks I ran, maybe the storybook - but now I moved it back

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@mistic mistic changed the title [Ops] Update babel to 7.21 [7.17][Ops] Update babel to 7.21 Jul 5, 2023
@delanni
Copy link
Contributor Author

delanni commented Jul 5, 2023

I stole all the target versions from main with a script - so they should all be in sync now, the build still doesn't work out

@delanni delanni force-pushed the update-babel-7.21 branch from 933f0e7 to 2ff08f7 Compare July 5, 2023 11:30
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 5, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / persists comments in the original file
  • [job] [logs] Jest Tests #3 / useUrlParams deletes keys that do not have truthy values
  • [job] [logs] Jest Tests #3 / useUrlParams gets the expected values using the context

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 69 63 -6
cases 151 145 -6
dashboard 241 230 -11
data 467 457 -10
dataEnhanced 49 43 -6
dataVisualizer 242 232 -10
discover 1842 1527 -315
fleet 39 35 -4
indexPatternEditor 85 75 -10
indexPatternFieldEditor 156 145 -11
indexPatternManagement 498 434 -64
infra 266 162 -104
inputControlVis 325 295 -30
lens 353 277 -76
management 2 1 -1
maps 1667 1072 -595
ml 80 79 -1
monitoring 53 41 -12
regionMap 14 4 -10
reporting 77 56 -21
security 71 63 -8
securitySolution 994 880 -114
stackAlerts 183 157 -26
tileMap 14 4 -10
upgradeAssistant 12 7 -5
visDefaultEditor 213 163 -50
visTypeTimeseries 337 322 -15
visTypeVega 35 34 -1
visualizations 114 102 -12
visualize 89 67 -22
total -1566

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni closed this Jul 6, 2023
@delanni
Copy link
Contributor Author

delanni commented Jul 6, 2023

Superceded by #161278

@delanni delanni deleted the update-babel-7.21 branch May 2, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants