fix(NA): auto approve backport action by not looking for non-existent labels #160826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
mistic
added
the
release_note:skip
Ikuni17
reviewed
Jun 28, 2023
There was a problem hiding this comment.
Think this should work as well. Double checked the debug step output in
https://github.com/elastic/kibana/actions/runs/5406432600/jobs/9823305986
The title says removing the debug step, do you want to do that now as well?
Ikuni17
approved these changes
Jun 28, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 28, 2023
…#160826) I believe I found out what was wrong with the previous implementation of the action. We were trying to check for the existence of the backport label when the PR is created which is never there (as it gets added afterwards). This PR is replacing the checking of the label by the assert that the branch name on a backport starts with `backport` and the creator of the PR is kibanamachine. (cherry picked from commit 5ac9390)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 28, 2023
…#160826) I believe I found out what was wrong with the previous implementation of the action. We were trying to check for the existence of the backport label when the PR is created which is never there (as it gets added afterwards). This PR is replacing the checking of the label by the assert that the branch name on a backport starts with `backport` and the creator of the PR is kibanamachine. (cherry picked from commit 5ac9390)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 28, 2023
…160826) (#160829) # Backport This will backport the following commits from `main` to `8.9`: - [chore(NA): remove debug step on auto approve backport action (#160826)](#160826) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T23:09:20Z","message":"chore(NA): remove debug step on auto approve backport action (#160826)\n\nI believe I found out what was wrong with the previous implementation of\r\nthe action.\r\nWe were trying to check for the existence of the backport label when the\r\nPR is created which is never there (as it gets added afterwards).\r\n\r\nThis PR is replacing the checking of the label by the assert that the\r\nbranch name on a backport starts with `backport` and the creator of the\r\nPR is kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":160826,"url":"https://github.com/elastic/kibana/pull/160826","mergeCommit":{"message":"chore(NA): remove debug step on auto approve backport action (#160826)\n\nI believe I found out what was wrong with the previous implementation of\r\nthe action.\r\nWe were trying to check for the existence of the backport label when the\r\nPR is created which is never there (as it gets added afterwards).\r\n\r\nThis PR is replacing the checking of the label by the assert that the\r\nbranch name on a backport starts with `backport` and the creator of the\r\nPR is kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160826","number":160826,"mergeCommit":{"message":"chore(NA): remove debug step on auto approve backport action (#160826)\n\nI believe I found out what was wrong with the previous implementation of\r\nthe action.\r\nWe were trying to check for the existence of the backport label when the\r\nPR is created which is never there (as it gets added afterwards).\r\n\r\nThis PR is replacing the checking of the label by the assert that the\r\nbranch name on a backport starts with `backport` and the creator of the\r\nPR is kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
mistic
added a commit
that referenced
this pull request
Jun 29, 2023
…160826) (#160828) # Backport This will backport the following commits from `main` to `7.17`: - [chore(NA): remove debug step on auto approve backport action (#160826)](#160826) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T23:09:20Z","message":"chore(NA): remove debug step on auto approve backport action (#160826)\n\nI believe I found out what was wrong with the previous implementation of\r\nthe action.\r\nWe were trying to check for the existence of the backport label when the\r\nPR is created which is never there (as it gets added afterwards).\r\n\r\nThis PR is replacing the checking of the label by the assert that the\r\nbranch name on a backport starts with `backport` and the creator of the\r\nPR is kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":160826,"url":"https://github.com/elastic/kibana/pull/160826","mergeCommit":{"message":"chore(NA): remove debug step on auto approve backport action (#160826)\n\nI believe I found out what was wrong with the previous implementation of\r\nthe action.\r\nWe were trying to check for the existence of the backport label when the\r\nPR is created which is never there (as it gets added afterwards).\r\n\r\nThis PR is replacing the checking of the label by the assert that the\r\nbranch name on a backport starts with `backport` and the creator of the\r\nPR is kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160826","number":160826,"mergeCommit":{"message":"chore(NA): remove debug step on auto approve backport action (#160826)\n\nI believe I found out what was wrong with the previous implementation of\r\nthe action.\r\nWe were trying to check for the existence of the backport label when the\r\nPR is created which is never there (as it gets added afterwards).\r\n\r\nThis PR is replacing the checking of the label by the assert that the\r\nbranch name on a backport starts with `backport` and the creator of the\r\nPR is kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <[email protected]>
mistic
changed the title
|
@Ikuni17 just updated the pr title. Will remove the debug step in a following PR just to make sure everything works as expected now. Thanks for pointing that out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I found out what was wrong with the previous implementation of the action.
We were trying to check for the existence of the backport label when the PR is created which is never there (as it gets added afterwards).
This PR is replacing the checking of the label by the assert that the branch name on a backport starts with
backportand the creator of the PR is kibanamachine.