Skip to content

Commit

Permalink
[8.9] chore(NA): remove debug step on auto approve backport action (#…
Browse files Browse the repository at this point in the history
…160826) (#160829)

# Backport

This will backport the following commits from `main` to `8.9`:
- [chore(NA): remove debug step on auto approve backport action
(#160826)](#160826)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago
Costa","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T23:09:20Z","message":"chore(NA):
remove debug step on auto approve backport action (#160826)\n\nI believe
I found out what was wrong with the previous implementation of\r\nthe
action.\r\nWe were trying to check for the existence of the backport
label when the\r\nPR is created which is never there (as it gets added
afterwards).\r\n\r\nThis PR is replacing the checking of the label by
the assert that the\r\nbranch name on a backport starts with `backport`
and the creator of the\r\nPR is
kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0"],"number":160826,"url":"https://github.com/elastic/kibana/pull/160826","mergeCommit":{"message":"chore(NA):
remove debug step on auto approve backport action (#160826)\n\nI believe
I found out what was wrong with the previous implementation of\r\nthe
action.\r\nWe were trying to check for the existence of the backport
label when the\r\nPR is created which is never there (as it gets added
afterwards).\r\n\r\nThis PR is replacing the checking of the label by
the assert that the\r\nbranch name on a backport starts with `backport`
and the creator of the\r\nPR is
kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160826","number":160826,"mergeCommit":{"message":"chore(NA):
remove debug step on auto approve backport action (#160826)\n\nI believe
I found out what was wrong with the previous implementation of\r\nthe
action.\r\nWe were trying to check for the existence of the backport
label when the\r\nPR is created which is never there (as it gets added
afterwards).\r\n\r\nThis PR is replacing the checking of the label by
the assert that the\r\nbranch name on a backport starts with `backport`
and the creator of the\r\nPR is
kibanamachine.","sha":"5ac939091605a115420fa6e47307e70c2a157d9d"}}]}]
BACKPORT-->

Co-authored-by: Tiago Costa <[email protected]>
  • Loading branch information
kibanamachine and mistic authored Jun 28, 2023
1 parent 2e8f818 commit 304d96f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/auto-approve-backports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
name: Auto-approve backport
runs-on: ubuntu-latest
if: |
contains(github.event.pull_request_target.labels.*.name, 'backport') &&
github.event.pull_request_target.user.login == 'kibanamachine'
startsWith(github.event.pull_request.head.ref, 'backport') &&
github.event.pull_request.user.login == 'kibanamachine'
permissions:
pull-requests: write
steps:
Expand Down

0 comments on commit 304d96f

Please sign in to comment.