Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Scale diff functions summary #160708

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[Profiling] Scale diff functions summary #160708

merged 1 commit into from
Jun 28, 2023

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Jun 28, 2023 •
edited by kibanamachine
Loading

This PR fixes a problem where the Total sample summary value wasn't being scaled when a scale factor is selected.

Screenshot 2023-06-28 at 10 34 14 AM

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.9.0 labels Jun 28, 2023
@cauemarcondes cauemarcondes requested a review from a team as a code owner June 28, 2023 09:34
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 294.6KB 294.8KB +188.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 14 16 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 15 17 +2
securitySolution 492 496 +4
total +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rockdaboot
rockdaboot approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested and works for me.

@cauemarcondes cauemarcondes merged commit d0358f5 into elastic:main Jun 28, 2023
@cauemarcondes cauemarcondes deleted the profiling-scale-summary branch June 28, 2023 12:00
@kibanamachine kibanamachine mentioned this pull request Jun 28, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 28, 2023
@cauemarcondes
[Profiling] Scale diff functions summary (elastic#160708)
92b2b5b 
This PR fixes a problem where the Total sample summary value wasn't
being scaled when a scale factor is selected.

<img width="1794" alt="Screenshot 2023-06-28 at 10 34 14 AM"
src="https://github.com/elastic/kibana/assets/55978943/8a77d01c-ab10-4b53-b9fa-855a2710c78b">

(cherry picked from commit d0358f5)
kibanamachine added a commit that referenced this pull request Jun 28, 2023
@kibanamachine @cauemarcondes
[8.9] [Profiling] Scale diff functions summary (#160708) (#160733)
9b235d9 
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Profiling] Scale diff functions summary
(#160708)](#160708)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T12:00:55Z","message":"[Profiling]
Scale diff functions summary (#160708)\n\nThis PR fixes a problem where
the Total sample summary value wasn't\r\nbeing scaled when a scale
factor is selected.\r\n\r\n<img width=\"1794\" alt=\"Screenshot
2023-06-28 at 10 34 14
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/8a77d01c-ab10-4b53-b9fa-855a2710c78b\">","sha":"d0358f5d2d3b386230332d00fc7f99c295ed107a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.10.0"],"number":160708,"url":"https://github.com/elastic/kibana/pull/160708","mergeCommit":{"message":"[Profiling]
Scale diff functions summary (#160708)\n\nThis PR fixes a problem where
the Total sample summary value wasn't\r\nbeing scaled when a scale
factor is selected.\r\n\r\n<img width=\"1794\" alt=\"Screenshot
2023-06-28 at 10 34 14
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/8a77d01c-ab10-4b53-b9fa-855a2710c78b\">","sha":"d0358f5d2d3b386230332d00fc7f99c295ed107a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160708","number":160708,"mergeCommit":{"message":"[Profiling]
Scale diff functions summary (#160708)\n\nThis PR fixes a problem where
the Total sample summary value wasn't\r\nbeing scaled when a scale
factor is selected.\r\n\r\n<img width=\"1794\" alt=\"Screenshot
2023-06-28 at 10 34 14
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/8a77d01c-ab10-4b53-b9fa-855a2710c78b\">","sha":"d0358f5d2d3b386230332d00fc7f99c295ed107a"}}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockdaboot rockdaboot rockdaboot approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.9.0 v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cauemarcondes @apmmachine @kibana-ci @kibanamachine @rockdaboot