Skip to content

Commit

Permalink
[8.9] [Profiling] Scale diff functions summary (#160708) (#160733)
Browse files Browse the repository at this point in the history
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Profiling] Scale diff functions summary
(#160708)](#160708)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T12:00:55Z","message":"[Profiling]
Scale diff functions summary (#160708)\n\nThis PR fixes a problem where
the Total sample summary value wasn't\r\nbeing scaled when a scale
factor is selected.\r\n\r\n<img width=\"1794\" alt=\"Screenshot
2023-06-28 at 10 34 14
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/8a77d01c-ab10-4b53-b9fa-855a2710c78b\">","sha":"d0358f5d2d3b386230332d00fc7f99c295ed107a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.9.0","v8.10.0"],"number":160708,"url":"https://github.com/elastic/kibana/pull/160708","mergeCommit":{"message":"[Profiling]
Scale diff functions summary (#160708)\n\nThis PR fixes a problem where
the Total sample summary value wasn't\r\nbeing scaled when a scale
factor is selected.\r\n\r\n<img width=\"1794\" alt=\"Screenshot
2023-06-28 at 10 34 14
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/8a77d01c-ab10-4b53-b9fa-855a2710c78b\">","sha":"d0358f5d2d3b386230332d00fc7f99c295ed107a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160708","number":160708,"mergeCommit":{"message":"[Profiling]
Scale diff functions summary (#160708)\n\nThis PR fixes a problem where
the Total sample summary value wasn't\r\nbeing scaled when a scale
factor is selected.\r\n\r\n<img width=\"1794\" alt=\"Screenshot
2023-06-28 at 10 34 14
AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/8a77d01c-ab10-4b53-b9fa-855a2710c78b\">","sha":"d0358f5d2d3b386230332d00fc7f99c295ed107a"}}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
  • Loading branch information
kibanamachine and cauemarcondes authored Jun 28, 2023
1 parent 39e1bde commit 9b235d9
Showing 1 changed file with 26 additions and 10 deletions.
36 changes: 26 additions & 10 deletions x-pack/plugins/profiling/public/components/topn_functions/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,28 @@ interface Row {
}

function TotalSamplesStat({
totalSamples,
newSamples,
baselineTotalSamples,
baselineScaleFactor,
comparisonTotalSamples,
comparisonScaleFactor,
}: {
totalSamples: number;
newSamples: number | undefined;
baselineTotalSamples: number;
baselineScaleFactor?: number;
comparisonTotalSamples?: number;
comparisonScaleFactor?: number;
}) {
const value = totalSamples.toLocaleString();
const scaledBaselineTotalSamples = scaleValue({
value: baselineTotalSamples,
scaleFactor: baselineScaleFactor,
});

const value = scaledBaselineTotalSamples.toLocaleString();

const sampleHeader = i18n.translate('xpack.profiling.functionsView.totalSampleCountLabel', {
defaultMessage: ' Total sample estimate: ',
});

if (newSamples === undefined || newSamples === 0) {
if (comparisonTotalSamples === undefined || comparisonTotalSamples === 0) {
return (
<EuiStat
title={<EuiText style={{ fontWeight: 'bold' }}>{value}</EuiText>}
Expand All @@ -67,8 +76,13 @@ function TotalSamplesStat({
);
}

const diffSamples = totalSamples - newSamples;
const percentDelta = (diffSamples / (totalSamples - diffSamples)) * 100;
const scaledComparisonTotalSamples = scaleValue({
value: comparisonTotalSamples,
scaleFactor: comparisonScaleFactor,
});

const diffSamples = scaledBaselineTotalSamples - scaledComparisonTotalSamples;
const percentDelta = (diffSamples / (scaledBaselineTotalSamples - diffSamples)) * 100;

return (
<EuiStat
Expand Down Expand Up @@ -404,8 +418,10 @@ export function TopNFunctionsTable({
return (
<>
<TotalSamplesStat
totalSamples={totalCount}
newSamples={comparisonTopNFunctions?.TotalCount}
baselineTotalSamples={totalCount}
baselineScaleFactor={baselineScaleFactor}
comparisonTotalSamples={comparisonTopNFunctions?.TotalCount}
comparisonScaleFactor={comparisonScaleFactor}
/>
<EuiSpacer size="s" />
<EuiHorizontalRule margin="none" style={{ height: 2 }} />
Expand Down

0 comments on commit 9b235d9

Please sign in to comment.