[Security Solution] Remove rule update/install callouts #160269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcrzx
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
xcrzx
changed the title
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @xcrzx |
jpdjere
approved these changes
Jun 22, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 23, 2023
## Summary This PR removes the callouts displaying new or updated rules. Given that the callouts cannot be dismissed, we've decided to remove them temporarily to prevent UI clutter, as there may be other callouts on the page. We're going to reintroduce these callouts in 8.10 with the ability to dismiss them till the next detection rules package release. Ticket to re-add the callouts in 8.10: elastic#160270 (cherry picked from commit 4dfb7bc)
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2023
… (#160359) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution] Remove rule update/install callouts (#160269)](#160269) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dmitrii Shevchenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-23T08:08:24Z","message":"[Security Solution] Remove rule update/install callouts (#160269)\n\n## Summary\r\n\r\nThis PR removes the callouts displaying new or updated rules. Given that\r\nthe callouts cannot be dismissed, we've decided to remove them\r\ntemporarily to prevent UI clutter, as there may be other callouts on the\r\npage. We're going to reintroduce these callouts in 8.10 with the ability\r\nto dismiss them till the next detection rules package release.\r\n\r\nTicket to re-add the callouts in 8.10:\r\nhttps://github.com//issues/160270","sha":"4dfb7bcdb9e021360d56364bc1eef142e6682c68","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Detection Rules","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","v8.9.0","v8.10.0"],"number":160269,"url":"https://github.com/elastic/kibana/pull/160269","mergeCommit":{"message":"[Security Solution] Remove rule update/install callouts (#160269)\n\n## Summary\r\n\r\nThis PR removes the callouts displaying new or updated rules. Given that\r\nthe callouts cannot be dismissed, we've decided to remove them\r\ntemporarily to prevent UI clutter, as there may be other callouts on the\r\npage. We're going to reintroduce these callouts in 8.10 with the ability\r\nto dismiss them till the next detection rules package release.\r\n\r\nTicket to re-add the callouts in 8.10:\r\nhttps://github.com//issues/160270","sha":"4dfb7bcdb9e021360d56364bc1eef142e6682c68"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160269","number":160269,"mergeCommit":{"message":"[Security Solution] Remove rule update/install callouts (#160269)\n\n## Summary\r\n\r\nThis PR removes the callouts displaying new or updated rules. Given that\r\nthe callouts cannot be dismissed, we've decided to remove them\r\ntemporarily to prevent UI clutter, as there may be other callouts on the\r\npage. We're going to reintroduce these callouts in 8.10 with the ability\r\nto dismiss them till the next detection rules package release.\r\n\r\nTicket to re-add the callouts in 8.10:\r\nhttps://github.com//issues/160270","sha":"4dfb7bcdb9e021360d56364bc1eef142e6682c68"}}]}] BACKPORT--> Co-authored-by: Dmitrii Shevchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the callouts displaying new or updated rules. Given that the callouts cannot be dismissed, we've decided to remove them temporarily to prevent UI clutter, as there may be other callouts on the page. We're going to reintroduce these callouts in 8.10 with the ability to dismiss them till the next detection rules package release.
Ticket to re-add the callouts in 8.10: #160270