Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Show callouts when new prebuilt rules or rule updates are available #160270

Open
Tracked by #179907
xcrzx opened this issue Jun 22, 2023 · 2 comments
Open
Tracked by #179907

[Security Solution] Show callouts when new prebuilt rules or rule updates are available #160270

xcrzx opened this issue Jun 22, 2023 · 2 comments
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@xcrzx
Copy link
Contributor

xcrzx commented Jun 22, 2023

Summary

  1. Re-add callouts removed in [Security Solution] Remove rule update/install callouts #160269.
  2. Show the callouts once a new detection engine package version is available
  3. Make the callouts dismissable. I.e., when a user closes them, they should stay hidden till the next package release.
@xcrzx xcrzx added Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team 8.10 candidate labels Jun 22, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@xcrzx xcrzx mentioned this issue Jun 22, 2023
Merged
@banderror banderror added Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area and removed Feature:Detection Rules Security Solution rules and Detection Engine labels Jun 22, 2023
xcrzx added a commit that referenced this issue Jun 23, 2023
@xcrzx
[Security Solution] Remove rule update/install callouts (#160269)
4dfb7bc 
## Summary

This PR removes the callouts displaying new or updated rules. Given that
the callouts cannot be dismissed, we've decided to remove them
temporarily to prevent UI clutter, as there may be other callouts on the
page. We're going to reintroduce these callouts in 8.10 with the ability
to dismiss them till the next detection rules package release.

Ticket to re-add the callouts in 8.10:
#160270
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 23, 2023
@xcrzx
[Security Solution] Remove rule update/install callouts (elastic#160269)
d4523d2 
## Summary

This PR removes the callouts displaying new or updated rules. Given that
the callouts cannot be dismissed, we've decided to remove them
temporarily to prevent UI clutter, as there may be other callouts on the
page. We're going to reintroduce these callouts in 8.10 with the ability
to dismiss them till the next detection rules package release.

Ticket to re-add the callouts in 8.10:
elastic#160270

(cherry picked from commit 4dfb7bc)
@jpdjere jpdjere mentioned this issue Jun 27, 2023
Merged
kibanamachine added a commit that referenced this issue Jun 30, 2023
@kibanamachine @xcrzx
[8.9] [Security Solution] Remove rule update/install callouts (#160269)…
4b3def9 
… (#160359)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] Remove rule update/install callouts
(#160269)](#160269)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dmitrii
Shevchenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-23T08:08:24Z","message":"[Security
Solution] Remove rule update/install callouts (#160269)\n\n##
Summary\r\n\r\nThis PR removes the callouts displaying new or updated
rules. Given that\r\nthe callouts cannot be dismissed, we've decided to
remove them\r\ntemporarily to prevent UI clutter, as there may be other
callouts on the\r\npage. We're going to reintroduce these callouts in
8.10 with the ability\r\nto dismiss them till the next detection rules
package release.\r\n\r\nTicket to re-add the callouts in
8.10:\r\nhttps://github.com//issues/160270","sha":"4dfb7bcdb9e021360d56364bc1eef142e6682c68","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Detection
Rules","Team:Detections and Resp","Team:
SecuritySolution","Team:Detection Rule
Management","v8.9.0","v8.10.0"],"number":160269,"url":"https://github.com/elastic/kibana/pull/160269","mergeCommit":{"message":"[Security
Solution] Remove rule update/install callouts (#160269)\n\n##
Summary\r\n\r\nThis PR removes the callouts displaying new or updated
rules. Given that\r\nthe callouts cannot be dismissed, we've decided to
remove them\r\ntemporarily to prevent UI clutter, as there may be other
callouts on the\r\npage. We're going to reintroduce these callouts in
8.10 with the ability\r\nto dismiss them till the next detection rules
package release.\r\n\r\nTicket to re-add the callouts in
8.10:\r\nhttps://github.com//issues/160270","sha":"4dfb7bcdb9e021360d56364bc1eef142e6682c68"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160269","number":160269,"mergeCommit":{"message":"[Security
Solution] Remove rule update/install callouts (#160269)\n\n##
Summary\r\n\r\nThis PR removes the callouts displaying new or updated
rules. Given that\r\nthe callouts cannot be dismissed, we've decided to
remove them\r\ntemporarily to prevent UI clutter, as there may be other
callouts on the\r\npage. We're going to reintroduce these callouts in
8.10 with the ability\r\nto dismiss them till the next detection rules
package release.\r\n\r\nTicket to re-add the callouts in
8.10:\r\nhttps://github.com//issues/160270","sha":"4dfb7bcdb9e021360d56364bc1eef142e6682c68"}}]}]
BACKPORT-->

Co-authored-by: Dmitrii Shevchenko <[email protected]>
@banderror banderror mentioned this issue Jan 3, 2024
Open
@banderror banderror mentioned this issue Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xcrzx @banderror @elasticmachine