Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[synthetics] Isolate private location type from saved objects #160027

Merged
merged 24 commits into from
Jul 20, 2023
Merged

[synthetics] Isolate private location type from saved objects #160027

merged 24 commits into from
Jul 20, 2023

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Jun 20, 2023 •
edited by shahzad31
Loading

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Resolves #153475

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 self-assigned this Jul 19, 2023
@shahzad31 shahzad31 added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 19, 2023
@shahzad31 shahzad31 changed the title synthetics - isolate private location type from saved objects [synthetics] Isolate private location type from saved objects Jul 20, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 911.2KB 911.2KB +28.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@shahzad31 shahzad31 marked this pull request as ready for review July 20, 2023 15:18
@shahzad31 shahzad31 requested a review from a team as a code owner July 20, 2023 15:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Jul 20, 2023
@shahzad31 shahzad31 merged commit e4c4edd into elastic:main Jul 20, 2023
@shahzad31 shahzad31 deleted the feat/synthetics-private-location-separate-types branch July 20, 2023 16:36
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 20, 2023
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
@dominiqueclarke @shahzad31
[synthetics] Isolate private location type from saved objects (elasti…
4f36218 
…c#160027)

Co-authored-by: shahzad31 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@shahzad31 shahzad31

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Synthetics] Add / Get private location - isolate api interface from saved object interface
6 participants
@dominiqueclarke @apmmachine @kibana-ci @elasticmachine @shahzad31 @kibanamachine