upate tets

elastic · Jul 19, 2023 · 7b84e4b · 7b84e4b
1 parent 5280436
commit 7b84e4b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/x-pack/plugins/synthetics/common/runtime_types/monitor_management/locations.ts b/x-pack/plugins/synthetics/common/runtime_types/monitor_management/locations.ts
@@ -38,8 +38,8 @@ export const BandwidthLimitKeyCodec = tEnum<BandwidthLimitKey>(
 export type BandwidthLimitKeyType = t.TypeOf<typeof BandwidthLimitKeyCodec>;
 
 export const LocationGeoCodec = t.interface({
-  lat: t.union([t.null, t.number]),
-  lon: t.union([t.null, t.number]),
+  lat: t.union([t.string, t.number]),
+  lon: t.union([t.string, t.number]),
 });
 
 export const LocationStatusCodec = tEnum<LocationStatus>('LocationStatus', LocationStatus);

diff --git a/...lugins/synthetics/common/runtime_types/monitor_management/synthetics_private_locations.ts b/...lugins/synthetics/common/runtime_types/monitor_management/synthetics_private_locations.ts
@@ -18,7 +18,9 @@ export const PrivateLocationCodec = t.intersection([
     isServiceManaged: t.boolean,
     isInvalid: t.boolean,
     tags: t.array(t.string),
-    geo: t.interface({ lat: t.union([t.null, t.number]), lon: t.union([t.null, t.number]) }),
+    /* Empty Lat lon was accidentally saved as an empty string instead of undefined or null
+     * Need a migration to fix */
+    geo: t.interface({ lat: t.union([t.string, t.number]), lon: t.union([t.string, t.number]) }),
   }),
 ]);
 

diff --git a/x-pack/test/api_integration/apis/synthetics/services/private_location_test_service.ts b/x-pack/test/api_integration/apis/synthetics/services/private_location_test_service.ts
@@ -65,6 +65,7 @@ export class PrivateLocationTestService {
         lon: '',
       },
       concurrentMonitors: 1,
+      isServiceManaged: false,
     }));
 
     await server.savedObjects.create({