-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] [Document Level Security] Access Control sync history #159461
Conversation
Add type parameter to filter sync jobs according to the type. Add ButtonGroup with access control table.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Couple translation nitpicks, but looks good overall
...ublic/applications/enterprise_search_content/components/search_index/sync_jobs/sync_jobs.tsx
Outdated
Show resolved
Hide resolved
...ublic/applications/enterprise_search_content/components/search_index/sync_jobs/sync_jobs.tsx
Outdated
Show resolved
Hide resolved
...ublic/applications/enterprise_search_content/components/search_index/sync_jobs/sync_jobs.tsx
Outdated
Show resolved
Hide resolved
...ublic/applications/enterprise_search_content/components/search_index/sync_jobs/sync_jobs.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Content related syncs
Access control syncs
When access control not enabled
Checklist
Delete any items that are not applicable to this PR.