Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] [Document Level Security] Access Control sync history #159461

Merged
merged 7 commits into from
Jun 12, 2023

Conversation

efegurkan
Copy link
Member

@efegurkan efegurkan commented Jun 12, 2023

Summary

  • Adds Access Control sync to the index overview page.
  • Adds table switcher and changes table columns.

Content related syncs
Screenshot 2023-06-12 at 14 49 10

Access control syncs
Screenshot 2023-06-12 at 14 49 14

When access control not enabled
Screenshot 2023-06-12 at 14 54 11

Checklist

Delete any items that are not applicable to this PR.

efegurkan added 3 commits June 9, 2023 18:57
Add type parameter to filter sync jobs according to the type.
Add ButtonGroup with access control table.
@efegurkan efegurkan added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.9.0 labels Jun 12, 2023
@efegurkan efegurkan requested a review from a team June 12, 2023 12:52
@efegurkan
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Couple translation nitpicks, but looks good overall

@efegurkan efegurkan enabled auto-merge (squash) June 12, 2023 14:24
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efegurkan efegurkan merged commit ebcfebe into elastic:main Jun 12, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2102 2103 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.4MB 2.4MB +1.8KB
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 410 414 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 491 495 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 12, 2023
@efegurkan efegurkan deleted the sync-history branch October 26, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants