[Ingest Pipelines] Fix functional tests

[ElenaStoeva]

Fixes #157511

Summary

This PR fixes the functional tests for Ingest Pipelines. Apparently, previously the test environment didn't have any automatically generated ingest pipelines and the tests were expecting an empty screen, but now there are three auto-generated managed pipelines, which is why the tests were failing.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[ElenaStoeva]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

[sabarasaba]

Thanks for having a look at this @ElenaStoeva!

I believe this pipelines are suppoused to be cleaned up by whoever created them, so its ok for our tests to expect to have the empty state in the UI.

For the behavioral_analytics-events-final_pipeline I see there were some conversations about it that @yuliacech started.

And for the other two perhaps a test is not cleaning up after themselves? 🤔

[ElenaStoeva]

Hey @sabarasaba, thanks for looking into this and for sending me the conversation about the behavioral_analytics-events-final_pipeline. It was mentioned in this discussion that a fix has been merged a month ago that would add the pipeline only when there are analytics collections, but it seems the pipeline is still created for some reason, so I'll ping the team to ask why this is the case.

Regarding the logs-default-pipeline, I see that this is coming from Elasticsearch and it has been added with elastic/elasticsearch#95971.

For the logs@json-message pipeline, this one has also been added 2 weeks ago with elastic/elasticsearch#96083.

Finally, I noticed that these 3 pipelines are regenerated even after I delete them in the test environment. So it seems the problem is not that the test user is not able to delete them, but that they always get recreated.

Overall, I wonder if we should change the tests so that they match the new scenario with the autogenerated pipelines and so they don't fail in the future if another such pipeline is added to Elasticsearch. What do you think?

[alisonelizabeth]

Thanks for looking into this @ElenaStoeva! My suggestion would be to make this test more future-proof.

We can create our own "test" pipeline as part of the test setup and confirm it exists in UI. Then, we should make sure to delete on cleanup. That way, the test isn't dependent on any changes that might be made outside of our control.

[ElenaStoeva]

Thanks for looking into this @ElenaStoeva! My suggestion would be to make this test more future-proof.

We can create our own "test" pipeline as part of the test setup and confirm it exists in UI. Then, we should make sure to delete on cleanup. That way, the test isn't dependent on any changes that might be made outside of our control.

Thanks for the suggestion @alisonelizabeth! I think this is a great idea for making the test future-proof.

[ElenaStoeva]

@elasticmachine merge upstream

[ElenaStoeva]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: a6b1444

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
enterpriseSearch	19	21	+2
securitySolution	410	414	+4
total			+6

Total ESLint disabled count

id	before	after	diff
enterpriseSearch	20	22	+2
securitySolution	491	495	+4
total			+6

History

• 💔 Build #134287 failed a9473e7
• 💚 Build #133936 succeeded 58f894b
• 💔 Build #133782 failed be0d310

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

[alisonelizabeth]

Thanks for updating the test @ElenaStoeva! This looks good. Have you had a chance to run it through the flaky test runner yet? Let me know if you need help here.

[ElenaStoeva]

Thanks for updating the test @ElenaStoeva! This looks good. Have you had a chance to run it through the flaky test runner yet? Let me know if you need help here.

Thanks for looking into this @alisonelizabeth! I just ran the flaky test runner and it passed: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2417

[alisonelizabeth]

LGTM. Thanks @ElenaStoeva!