Skip to content

Commit

Permalink
[Security Solution] remove history tab from expandable flyout (#159273)
Browse files Browse the repository at this point in the history
  • Loading branch information
PhilippeOberti authored Jun 12, 2023
1 parent 988b2f4 commit ab0285f
Show file tree
Hide file tree
Showing 10 changed files with 4 additions and 48 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export interface PanelContentProps {

/**
* Document details expandable flyout left section. Appears after the user clicks on the expand details button in the right section.
* Will display the content of the visualize, investigation, insights and history tabs.
* Will display the content of the visualize, investigation and insights tabs.
*/
export const PanelContent: VFC<PanelContentProps> = ({ selectedTabId }) => {
const selectedTabContent = useMemo(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import type { LeftPanelTabsType } from './tabs';
import { tabs } from './tabs';
import { useLeftPanelContext } from './context';

export type LeftPanelPaths = 'visualize' | 'insights' | 'investigation' | 'history';
export type LeftPanelPaths = 'visualize' | 'insights' | 'investigation';
export const LeftPanelKey: LeftPanelProps['key'] = 'document-details-left';

export const LeftPanelInsightsTabPath: LeftPanelProps['path'] = ['insights'];
Expand Down
16 changes: 2 additions & 14 deletions x-pack/plugins/security_solution/public/flyout/left/tabs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,10 @@
import React from 'react';
import { VisualizeTab } from './tabs/visualize_tab';
import { InvestigationTab } from './tabs/investigation_tab';
import { HISTORY_TAB, INSIGHTS_TAB, INVESTIGATIONS_TAB, VISUALIZE_TAB } from './translations';
import { INSIGHTS_TAB, INVESTIGATIONS_TAB, VISUALIZE_TAB } from './translations';
import { InsightsTab } from './tabs/insights_tab';
import { HistoryTab } from './tabs/history_tab';
import type { LeftPanelPaths } from '.';
import {
HISTORY_TAB_TEST_ID,
INSIGHTS_TAB_TEST_ID,
INVESTIGATION_TAB_TEST_ID,
VISUALIZE_TAB_TEST_ID,
} from './test_ids';
import { INSIGHTS_TAB_TEST_ID, INVESTIGATION_TAB_TEST_ID, VISUALIZE_TAB_TEST_ID } from './test_ids';

export type LeftPanelTabsType = Array<{
id: LeftPanelPaths;
Expand Down Expand Up @@ -45,10 +39,4 @@ export const tabs: LeftPanelTabsType = [
name: INVESTIGATIONS_TAB,
content: <InvestigationTab />,
},
{
id: 'history',
'data-test-subj': HISTORY_TAB_TEST_ID,
name: HISTORY_TAB,
content: <HistoryTab />,
},
];

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,3 @@ export const INSIGHTS_TAB_RESPONSE_BUTTON_TEST_ID =
'securitySolutionDocumentDetailsFlyoutInsightsTabResponseButton';
export const INVESTIGATION_TAB_CONTENT_TEST_ID =
'securitySolutionDocumentDetailsFlyoutInvestigationsTabContent';
export const HISTORY_TAB_CONTENT_TEST_ID = 'securitySolutionDocumentDetailsFlyoutHistoryTabContent';
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,3 @@
export const VISUALIZE_TAB_TEST_ID = 'securitySolutionDocumentDetailsFlyoutVisualizeTab';
export const INSIGHTS_TAB_TEST_ID = 'securitySolutionDocumentDetailsFlyoutInsightsTab';
export const INVESTIGATION_TAB_TEST_ID = 'securitySolutionDocumentDetailsFlyoutInvestigationTab';
export const HISTORY_TAB_TEST_ID = 'securitySolutionDocumentDetailsFlyoutHistoryTab';
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,3 @@ export const INVESTIGATIONS_TAB = i18n.translate(
defaultMessage: 'Investigation',
}
);

export const HISTORY_TAB = i18n.translate(
'xpack.securitySolution.flyout.documentDetails.historyTab',
{
defaultMessage: 'History',
}
);
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -32446,7 +32446,6 @@
"xpack.securitySolution.flyout.documentDetails.expandDetailButton": "Développer les détails de l'alerte",
"xpack.securitySolution.flyout.documentDetails.headerTitle": "Détails des documents",
"xpack.securitySolution.flyout.documentDetails.highlightedFieldsTitle": "Champs en surbrillance",
"xpack.securitySolution.flyout.documentDetails.historyTab": "Historique",
"xpack.securitySolution.flyout.documentDetails.insightsOptions": "Options des informations exploitables",
"xpack.securitySolution.flyout.documentDetails.insightsTab": "Informations exploitables",
"xpack.securitySolution.flyout.documentDetails.insightsTitle": "Informations exploitables",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -32427,7 +32427,6 @@
"xpack.securitySolution.flyout.documentDetails.expandDetailButton": "アラート詳細を展開",
"xpack.securitySolution.flyout.documentDetails.headerTitle": "ドキュメント詳細",
"xpack.securitySolution.flyout.documentDetails.highlightedFieldsTitle": "ハイライトされたフィールド",
"xpack.securitySolution.flyout.documentDetails.historyTab": "履歴",
"xpack.securitySolution.flyout.documentDetails.insightsOptions": "インサイトオプション",
"xpack.securitySolution.flyout.documentDetails.insightsTab": "インサイト",
"xpack.securitySolution.flyout.documentDetails.insightsTitle": "インサイト",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -32423,7 +32423,6 @@
"xpack.securitySolution.flyout.documentDetails.expandDetailButton": "展开告警详情",
"xpack.securitySolution.flyout.documentDetails.headerTitle": "文档详情",
"xpack.securitySolution.flyout.documentDetails.highlightedFieldsTitle": "突出显示的字段",
"xpack.securitySolution.flyout.documentDetails.historyTab": "历史记录",
"xpack.securitySolution.flyout.documentDetails.insightsOptions": "洞见选项",
"xpack.securitySolution.flyout.documentDetails.insightsTab": "洞见",
"xpack.securitySolution.flyout.documentDetails.insightsTitle": "洞见",
Expand Down

0 comments on commit ab0285f

Please sign in to comment.