-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security solution][Endpoint] Remove unnecessary experimental feature flags from plugin config #158969
[Security solution][Endpoint] Remove unnecessary experimental feature flags from plugin config #158969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement!
Feel free to delete this code:
/**
* Keep DEPRECATED experimental flags that are documented to prevent failed upgrades.
* https://www.elastic.co/guide/en/security/current/user-risk-score.html
* https://www.elastic.co/guide/en/security/current/host-risk-score.html
*
* Issue: https://github.com/elastic/kibana/issues/146777
*/
riskyHostsEnabled: false, // DEPRECATED
riskyUsersEnabled: false, // DEPRECATED
…sed-experimental-feature-keys # Conflicts: # x-pack/plugins/security_solution/common/experimental_features.ts # x-pack/plugins/security_solution/server/lib/app_features/security_kibana_features.ts
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me: reads PR title, oh this should be easy
PR: 40 file changes
🤣
thanks for the cleanup 🔥
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explore code looks good to me.
I noticed that riskyUsersEnabled
and riskyHostsEnabled
are still present in the branch.
…59299) ## Summary Delete `riskyHostsEnabled` and `riskyUsersEnabled` flags. Follow up on this change #158969 Co-authored-by: Kibana Machine <[email protected]>
Summary
xpack.securitySolution.enableExperimental
values (defined in thekibana.yml
) so that unknown/unsupported values will no longer prevent the application from starting (will no longerthrow
)setup
will now output a message (warning) to the log if it finds experimental feature values that are not supported.policyListEnabled
diableIsolationUIPendingStatuses
responseActionsConsoleEnabled
endpointRbacEnabled
endpointRbacV1Enabled
responseActionGetFileEnabled
responseActionExecuteEnabled
pendingActionResponsesWithAck
policyResponseInFleetEnabled
riskyUsersEnabled
riskyHostsEnabled
Message to kibana log when unsupported values are defined: