Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution][Endpoint] Remove unnecessary experimental feature flags from plugin config #158969

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Jun 2, 2023

Summary

  • Changes the behaviour of the validation of xpack.securitySolution.enableExperimental values (defined in the kibana.yml) so that unknown/unsupported values will no longer prevent the application from starting (will no longer throw)
    • This change is only done in the config schema validation
    • Plugin's setup will now output a message (warning) to the log if it finds experimental feature values that are not supported.
  • Removes the following experimental feature flags (no longer needed):
    • policyListEnabled
    • diableIsolationUIPendingStatuses
    • responseActionsConsoleEnabled
    • endpointRbacEnabled
    • endpointRbacV1Enabled
    • responseActionGetFileEnabled
    • responseActionExecuteEnabled
    • pendingActionResponsesWithAck
    • policyResponseInFleetEnabled
    • riskyUsersEnabled
    • riskyHostsEnabled

Message to kibana log when unsupported values are defined:

[2023-06-02T16:37:48.997-04:00][WARN ][plugins.securitySolution.config] Unsupported "xpack.securitySolution.enableExperimental" values detected.
The following configuration values are no longer supported and should be removed from the kibana configuration file:

    xpack.securitySolution.enableExperimental:
      - endpointRbacEnabled
      - responseActionGetFileEnabled
      - responseActionExecuteEnabled

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.9.0 labels Jun 2, 2023
@paul-tavares paul-tavares self-assigned this Jun 2, 2023
Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement!

Feel free to delete this code:

/**
   * Keep DEPRECATED experimental flags that are documented to prevent failed upgrades.
   * https://www.elastic.co/guide/en/security/current/user-risk-score.html
   * https://www.elastic.co/guide/en/security/current/host-risk-score.html
   *
   * Issue: https://github.com/elastic/kibana/issues/146777
   */
  riskyHostsEnabled: false, // DEPRECATED
  riskyUsersEnabled: false, // DEPRECATED

@paul-tavares paul-tavares marked this pull request as ready for review June 5, 2023 18:58
@paul-tavares paul-tavares requested review from a team as code owners June 5, 2023 18:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@paul-tavares paul-tavares requested a review from machadoum June 7, 2023 13:23
Copy link
Member

@joeypoon joeypoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me: reads PR title, oh this should be easy
PR: 40 file changes
🤣

thanks for the cleanup 🔥

@paul-tavares paul-tavares enabled auto-merge (squash) June 7, 2023 14:26
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Tests #1 / Detections : Page Filters Alert Page Filters Customization should not sync to the URL in edit mode but only in view mode

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4105 4103 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.8MB 10.8MB -2.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 51.4KB 51.0KB -356.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 413 418 +5
total +7

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 497 502 +5
total +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

Copy link
Member

@machadoum machadoum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explore code looks good to me.
I noticed that riskyUsersEnabled and riskyHostsEnabled are still present in the branch.

@paul-tavares paul-tavares merged commit 3bb4edf into elastic:main Jun 8, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 8, 2023
@paul-tavares paul-tavares deleted the task/olm-remove-unused-experimental-feature-keys branch June 8, 2023 13:26
machadoum added a commit that referenced this pull request Jun 22, 2023
…59299)

## Summary

Delete `riskyHostsEnabled` and `riskyUsersEnabled` flags.

Follow up on this change #158969

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants