Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Update "securitySolution.enableExperimental" not allowed values validation to be a warning #146777

Closed
machadoum opened this issue Dec 1, 2022 · 1 comment
Assignees
Labels
enhancement New value added to drive a business result OLM Sprint Team:Defend Workflows “EDR Workflows” sub-team of Security Solution

Comments

@machadoum
Copy link
Member

machadoum commented Dec 1, 2022

Users can’t upgrade their clusters when an old experimental feature is enabled.

A failed upgrade due to a deprecated experimental flag enabled in the environment is a frustrating experience for users. Since the old flag doesn’t break any functionality, we could treat it as a warning instead of a server crash.

Links

Original report: https://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339

@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 1, 2022
@machadoum machadoum added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution grooming enhancement New value added to drive a business result and removed needs-team Issues missing a team label labels Dec 1, 2022
@machadoum machadoum changed the title [Security Solution] Update securitySolution.enableExperimental not allowed values validation to be a warning [Security Solution] Update "securitySolution.enableExperimental" not allowed values validation to be a warning Dec 1, 2022
machadoum added a commit that referenced this issue Dec 1, 2022
…ental feature is enabled (#146780)

Users can't upgrade their clusters when an old experimental feature is
enabled.

While we don't have a final solution for this issue, I am adding the
experimental flag configuration back to prevent users from having this
frustrating experience.

Quick-fix for: #146777
Original report:
https://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339

Fix
```
FATAL Error: [config validation of [xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not allowed. Allowed values are: tGridEnabled, tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled, kubernetesEnabled, disableIsolationUIPendingStatuses, pendingActionResponsesWithAck, policyListEnabled, policyResponseInFleetEnabled, previewTelemetryUrlEnabled, responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry, extendedRuleExecutionLoggingEnabled, socTrendsEnabled, responseActionsEnabled
```

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 1, 2022
…ental feature is enabled (elastic#146780)

Users can't upgrade their clusters when an old experimental feature is
enabled.

While we don't have a final solution for this issue, I am adding the
experimental flag configuration back to prevent users from having this
frustrating experience.

Quick-fix for: elastic#146777
Original report:
https://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339

Fix
```
FATAL Error: [config validation of [xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not allowed. Allowed values are: tGridEnabled, tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled, kubernetesEnabled, disableIsolationUIPendingStatuses, pendingActionResponsesWithAck, policyListEnabled, policyResponseInFleetEnabled, previewTelemetryUrlEnabled, responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry, extendedRuleExecutionLoggingEnabled, socTrendsEnabled, responseActionsEnabled
```

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit c3d1d9e)
kibanamachine referenced this issue Dec 1, 2022
…xperimental feature is enabled (#146780) (#146813)

# Backport

This will backport the following commits from `main` to `8.6`:
- [Quick-fix Users can’t upgrade their clusters when `riskScore`
experimental feature is enabled
(#146780)](#146780)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-01T17:25:46Z","message":"Quick-fix
Users can’t upgrade their clusters when `riskScore` experimental feature
is enabled (#146780)\n\nUsers can't upgrade their clusters when an old
experimental feature is\r\nenabled.\r\n\r\nWhile we don't have a final
solution for this issue, I am adding the\r\nexperimental flag
configuration back to prevent users from having this\r\nfrustrating
experience.\r\n\r\nQuick-fix for:
https://github.com/elastic/kibana/issues/146777\r\nOriginal
report:\r\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\r\n\r\nFix\r\n```\r\nFATAL
Error: [config validation of
[xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not
allowed. Allowed values are: tGridEnabled,
tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled,
kubernetesEnabled, disableIsolationUIPendingStatuses,
pendingActionResponsesWithAck, policyListEnabled,
policyResponseInFleetEnabled, previewTelemetryUrlEnabled,
responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry,
extendedRuleExecutionLoggingEnabled, socTrendsEnabled,
responseActionsEnabled\r\n```\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.6.0","v8.7.0","v8.6.1"],"number":146780,"url":"https://github.com/elastic/kibana/pull/146780","mergeCommit":{"message":"Quick-fix
Users can’t upgrade their clusters when `riskScore` experimental feature
is enabled (#146780)\n\nUsers can't upgrade their clusters when an old
experimental feature is\r\nenabled.\r\n\r\nWhile we don't have a final
solution for this issue, I am adding the\r\nexperimental flag
configuration back to prevent users from having this\r\nfrustrating
experience.\r\n\r\nQuick-fix for:
https://github.com/elastic/kibana/issues/146777\r\nOriginal
report:\r\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\r\n\r\nFix\r\n```\r\nFATAL
Error: [config validation of
[xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not
allowed. Allowed values are: tGridEnabled,
tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled,
kubernetesEnabled, disableIsolationUIPendingStatuses,
pendingActionResponsesWithAck, policyListEnabled,
policyResponseInFleetEnabled, previewTelemetryUrlEnabled,
responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry,
extendedRuleExecutionLoggingEnabled, socTrendsEnabled,
responseActionsEnabled\r\n```\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146780","number":146780,"mergeCommit":{"message":"Quick-fix
Users can’t upgrade their clusters when `riskScore` experimental feature
is enabled (#146780)\n\nUsers can't upgrade their clusters when an old
experimental feature is\r\nenabled.\r\n\r\nWhile we don't have a final
solution for this issue, I am adding the\r\nexperimental flag
configuration back to prevent users from having this\r\nfrustrating
experience.\r\n\r\nQuick-fix for:
https://github.com/elastic/kibana/issues/146777\r\nOriginal
report:\r\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\r\n\r\nFix\r\n```\r\nFATAL
Error: [config validation of
[xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not
allowed. Allowed values are: tGridEnabled,
tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled,
kubernetesEnabled, disableIsolationUIPendingStatuses,
pendingActionResponsesWithAck, policyListEnabled,
policyResponseInFleetEnabled, previewTelemetryUrlEnabled,
responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry,
extendedRuleExecutionLoggingEnabled, socTrendsEnabled,
responseActionsEnabled\r\n```\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e"}}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <[email protected]>
machadoum added a commit to machadoum/kibana that referenced this issue Dec 5, 2022
…ental feature is enabled (elastic#146780)

Users can't upgrade their clusters when an old experimental feature is
enabled.

While we don't have a final solution for this issue, I am adding the
experimental flag configuration back to prevent users from having this
frustrating experience.

Quick-fix for: elastic#146777
Original report:
https://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339

Fix
```
FATAL Error: [config validation of [xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not allowed. Allowed values are: tGridEnabled, tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled, kubernetesEnabled, disableIsolationUIPendingStatuses, pendingActionResponsesWithAck, policyListEnabled, policyResponseInFleetEnabled, previewTelemetryUrlEnabled, responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry, extendedRuleExecutionLoggingEnabled, socTrendsEnabled, responseActionsEnabled
```

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit c3d1d9e)

# Conflicts:
#	x-pack/plugins/security_solution/common/experimental_features.ts
machadoum added a commit that referenced this issue Dec 5, 2022
…xperimental feature is enabled (#146780) (#146973)

# Backport

This will backport the following commits from `main` to `8.5`:
- [Quick-fix Users can’t upgrade their clusters when `riskScore`
experimental feature is enabled
(#146780)](#146780)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-01T17:25:46Z","message":"Quick-fix
Users can’t upgrade their clusters when `riskScore` experimental feature
is enabled (#146780)\n\nUsers can't upgrade their clusters when an old
experimental feature is\r\nenabled.\r\n\r\nWhile we don't have a final
solution for this issue, I am adding the\r\nexperimental flag
configuration back to prevent users from having this\r\nfrustrating
experience.\r\n\r\nQuick-fix for:
https://github.com/elastic/kibana/issues/146777\r\nOriginal
report:\r\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\r\n\r\nFix\r\n```\r\nFATAL
Error: [config validation of
[xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not
allowed. Allowed values are: tGridEnabled,
tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled,
kubernetesEnabled, disableIsolationUIPendingStatuses,
pendingActionResponsesWithAck, policyListEnabled,
policyResponseInFleetEnabled, previewTelemetryUrlEnabled,
responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry,
extendedRuleExecutionLoggingEnabled, socTrendsEnabled,
responseActionsEnabled\r\n```\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.6.0","v8.7.0","v8.6.1"],"number":146780,"url":"https://github.com/elastic/kibana/pull/146780","mergeCommit":{"message":"Quick-fix
Users can’t upgrade their clusters when `riskScore` experimental feature
is enabled (#146780)\n\nUsers can't upgrade their clusters when an old
experimental feature is\r\nenabled.\r\n\r\nWhile we don't have a final
solution for this issue, I am adding the\r\nexperimental flag
configuration back to prevent users from having this\r\nfrustrating
experience.\r\n\r\nQuick-fix for:
https://github.com/elastic/kibana/issues/146777\r\nOriginal
report:\r\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\r\n\r\nFix\r\n```\r\nFATAL
Error: [config validation of
[xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not
allowed. Allowed values are: tGridEnabled,
tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled,
kubernetesEnabled, disableIsolationUIPendingStatuses,
pendingActionResponsesWithAck, policyListEnabled,
policyResponseInFleetEnabled, previewTelemetryUrlEnabled,
responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry,
extendedRuleExecutionLoggingEnabled, socTrendsEnabled,
responseActionsEnabled\r\n```\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/146813","number":146813,"state":"MERGED","mergeCommit":{"sha":"acede4b442ca8e1eac9246316796d98bcf27e6c8","message":"[8.6]
Quick-fix Users can’t upgrade their clusters when `riskScore`
experimental feature is enabled (#146780) (#146813)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.6`:\n- [Quick-fix Users can’t upgrade their clusters when
`riskScore`\nexperimental feature is
enabled\n(#146780)](https://github.com/elastic/kibana/pull/146780)\n\n<!---
Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Pablo\nMachado\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2022-12-01T17:25:46Z\",\"message\":\"Quick-fix\nUsers
can’t upgrade their clusters when `riskScore` experimental feature\nis
enabled (#146780)\\n\\nUsers can't upgrade their clusters when an
old\nexperimental feature is\\r\\nenabled.\\r\\n\\r\\nWhile we don't
have a final\nsolution for this issue, I am adding the\\r\\nexperimental
flag\nconfiguration back to prevent users from having
this\\r\\nfrustrating\nexperience.\\r\\n\\r\\nQuick-fix
for:\nhttps://github.com//issues/146777\\r\\nOriginal\nreport:\\r\\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\\r\\n\\r\\nFix\\r\\n```\\r\\nFATAL\nError:
[config validation of\n[xpack.securitySolution].enableExperimental]:
[riskyUsersEnabled] is not\nallowed. Allowed values are:
tGridEnabled,\ntGridEventRenderedViewEnabled,
excludePoliciesInFilterEnabled,\nkubernetesEnabled,
disableIsolationUIPendingStatuses,\npendingActionResponsesWithAck,
policyListEnabled,\npolicyResponseInFleetEnabled,
previewTelemetryUrlEnabled,\nresponseActionsConsoleEnabled,
insightsRelatedAlertsByProcessAncestry,\nextendedRuleExecutionLoggingEnabled,
socTrendsEnabled,\nresponseActionsEnabled\\r\\n```\\r\\n\\r\\nCo-authored-by:
Kibana
Machine\n<[email protected]>\",\"sha\":\"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e\",\"branchLabelMapping\":{\"^v8.7.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:fix\",\"Team:Threat\nHunting\",\"Team:
SecuritySolution\",\"Team:Threat\nHunting:Explore\",\"v8.6.0\",\"v8.7.0\",\"v8.6.1\"],\"number\":146780,\"url\":\"https://github.com/elastic/kibana/pull/146780\",\"mergeCommit\":{\"message\":\"Quick-fix\nUsers
can’t upgrade their clusters when `riskScore` experimental feature\nis
enabled (#146780)\\n\\nUsers can't upgrade their clusters when an
old\nexperimental feature is\\r\\nenabled.\\r\\n\\r\\nWhile we don't
have a final\nsolution for this issue, I am adding the\\r\\nexperimental
flag\nconfiguration back to prevent users from having
this\\r\\nfrustrating\nexperience.\\r\\n\\r\\nQuick-fix
for:\nhttps://github.com//issues/146777\\r\\nOriginal\nreport:\\r\\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\\r\\n\\r\\nFix\\r\\n```\\r\\nFATAL\nError:
[config validation of\n[xpack.securitySolution].enableExperimental]:
[riskyUsersEnabled] is not\nallowed. Allowed values are:
tGridEnabled,\ntGridEventRenderedViewEnabled,
excludePoliciesInFilterEnabled,\nkubernetesEnabled,
disableIsolationUIPendingStatuses,\npendingActionResponsesWithAck,
policyListEnabled,\npolicyResponseInFleetEnabled,
previewTelemetryUrlEnabled,\nresponseActionsConsoleEnabled,
insightsRelatedAlertsByProcessAncestry,\nextendedRuleExecutionLoggingEnabled,
socTrendsEnabled,\nresponseActionsEnabled\\r\\n```\\r\\n\\r\\nCo-authored-by:
Kibana
Machine\n<[email protected]>\",\"sha\":\"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.6\"],\"targetPullRequestStates\":[{\"branch\":\"8.6\",\"label\":\"v8.6.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.7.0\",\"labelRegex\":\"^v8.7.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/146780\",\"number\":146780,\"mergeCommit\":{\"message\":\"Quick-fix\nUsers
can’t upgrade their clusters when `riskScore` experimental feature\nis
enabled (#146780)\\n\\nUsers can't upgrade their clusters when an
old\nexperimental feature is\\r\\nenabled.\\r\\n\\r\\nWhile we don't
have a final\nsolution for this issue, I am adding the\\r\\nexperimental
flag\nconfiguration back to prevent users from having
this\\r\\nfrustrating\nexperience.\\r\\n\\r\\nQuick-fix
for:\nhttps://github.com//issues/146777\\r\\nOriginal\nreport:\\r\\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\\r\\n\\r\\nFix\\r\\n```\\r\\nFATAL\nError:
[config validation of\n[xpack.securitySolution].enableExperimental]:
[riskyUsersEnabled] is not\nallowed. Allowed values are:
tGridEnabled,\ntGridEventRenderedViewEnabled,
excludePoliciesInFilterEnabled,\nkubernetesEnabled,
disableIsolationUIPendingStatuses,\npendingActionResponsesWithAck,
policyListEnabled,\npolicyResponseInFleetEnabled,
previewTelemetryUrlEnabled,\nresponseActionsConsoleEnabled,
insightsRelatedAlertsByProcessAncestry,\nextendedRuleExecutionLoggingEnabled,
socTrendsEnabled,\nresponseActionsEnabled\\r\\n```\\r\\n\\r\\nCo-authored-by:
Kibana
Machine\n<[email protected]>\",\"sha\":\"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Pablo Machado
<[email protected]>"}},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/146780","number":146780,"mergeCommit":{"message":"Quick-fix
Users can’t upgrade their clusters when `riskScore` experimental feature
is enabled (#146780)\n\nUsers can't upgrade their clusters when an old
experimental feature is\r\nenabled.\r\n\r\nWhile we don't have a final
solution for this issue, I am adding the\r\nexperimental flag
configuration back to prevent users from having this\r\nfrustrating
experience.\r\n\r\nQuick-fix for:
https://github.com/elastic/kibana/issues/146777\r\nOriginal
report:\r\nhttps://elastic.slack.com/archives/C6E3MTCD7/p1669236299374339\r\n\r\nFix\r\n```\r\nFATAL
Error: [config validation of
[xpack.securitySolution].enableExperimental]: [riskyUsersEnabled] is not
allowed. Allowed values are: tGridEnabled,
tGridEventRenderedViewEnabled, excludePoliciesInFilterEnabled,
kubernetesEnabled, disableIsolationUIPendingStatuses,
pendingActionResponsesWithAck, policyListEnabled,
policyResponseInFleetEnabled, previewTelemetryUrlEnabled,
responseActionsConsoleEnabled, insightsRelatedAlertsByProcessAncestry,
extendedRuleExecutionLoggingEnabled, socTrendsEnabled,
responseActionsEnabled\r\n```\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"c3d1d9ec284f81f3c5d713010e52cd9d4f09c39e"}}]}]
BACKPORT-->

Co-authored-by: kibanamachine <[email protected]>
@machadoum
Copy link
Member Author

#158969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result OLM Sprint Team:Defend Workflows “EDR Workflows” sub-team of Security Solution
Projects
None yet
Development

No branches or pull requests

2 participants