[Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule #158565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule for Snooze Notifications of Rule Co-authored-by: KlingerMatheus <[email protected]> Co-authored-by: gitstart_bot <[email protected]>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
gitstart
changed the title
Zacqary
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Looks good, thanks for contributing!
This fixes the issue in the UI but doesn't guard against a user creating a snooze with the same start and end time using the API. However in order to do that I believe you'd have to pass duration: 0, and that's not an easy mistake to make, as opposed to this UI behavior where it was very easy to accidentally pass the same start and end time. So I'm comfortable merging this and adding that guard to the API in another issue.
|
@elasticmachine merge upstream |
|
buildkite test this |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
|
@elasticmachine run elasticsearch-ci/docs |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 8, 2023
…ule for Snooze Notifications of Rule (elastic#158565) ## What does this PR do? * It doesn't allows the user to pick the same date and time in the schedule component. ## Issue References * Client: elastic#157865 ## Video/Screenshot Demo ###### FIX: https://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a --- This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time. Co-authored-by: KlingerMatheus <[email protected]> Co-authored-by: gitstart_bot <[email protected]> (cherry picked from commit d9eff3f)
kibanamachine
added a commit
that referenced
this pull request
Jun 8, 2023
… Schedule for Snooze Notifications of Rule (#158565) (#159331) # Backport This will backport the following commits from `main` to `8.8`: - [[Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule (#158565)](#158565) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"GitStart","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-08T15:57:03Z","message":"[Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule (#158565)\n\n## What does this PR do?\r\n* It doesn't allows the user to pick the same date and time in the\r\nschedule component.\r\n\r\n## Issue References\r\n* Client: https://github.com/elastic/kibana/issues/157865\r\n\r\n## Video/Screenshot Demo \r\n\r\n###### FIX:\r\nhttps://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a\r\n\r\n---\r\nThis code was written and reviewed by GitStart Community. Growing great\r\nengineers, one PR at a time.\r\n\r\nCo-authored-by: KlingerMatheus <[email protected]>\r\nCo-authored-by: gitstart_bot <[email protected]>","sha":"d9eff3fd84c7eb9da0f3d3e1106d6054b3a4cad7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","v8.9.0","v8.8.2"],"number":158565,"url":"https://github.com/elastic/kibana/pull/158565","mergeCommit":{"message":"[Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule (#158565)\n\n## What does this PR do?\r\n* It doesn't allows the user to pick the same date and time in the\r\nschedule component.\r\n\r\n## Issue References\r\n* Client: https://github.com/elastic/kibana/issues/157865\r\n\r\n## Video/Screenshot Demo \r\n\r\n###### FIX:\r\nhttps://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a\r\n\r\n---\r\nThis code was written and reviewed by GitStart Community. Growing great\r\nengineers, one PR at a time.\r\n\r\nCo-authored-by: KlingerMatheus <[email protected]>\r\nCo-authored-by: gitstart_bot <[email protected]>","sha":"d9eff3fd84c7eb9da0f3d3e1106d6054b3a4cad7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158565","number":158565,"mergeCommit":{"message":"[Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule (#158565)\n\n## What does this PR do?\r\n* It doesn't allows the user to pick the same date and time in the\r\nschedule component.\r\n\r\n## Issue References\r\n* Client: https://github.com/elastic/kibana/issues/157865\r\n\r\n## Video/Screenshot Demo \r\n\r\n###### FIX:\r\nhttps://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a\r\n\r\n---\r\nThis code was written and reviewed by GitStart Community. Growing great\r\nengineers, one PR at a time.\r\n\r\nCo-authored-by: KlingerMatheus <[email protected]>\r\nCo-authored-by: gitstart_bot <[email protected]>","sha":"d9eff3fd84c7eb9da0f3d3e1106d6054b3a4cad7"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: GitStart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Issue References
Video/Screenshot Demo
FIX:
https://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.