Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM][Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule #157865

Closed
arvindersingh-qasource opened this issue May 16, 2023 · 7 comments
Closed

[RAM][Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule #157865

arvindersingh-qasource opened this issue May 16, 2023 · 7 comments
Assignees
@Zacqary
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX Feature:Rule Management Security Solution Detection Rule Management area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.2

Comments

@arvindersingh-qasource
Copy link

Describe the bug
Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule

Build Details

VERSION: 8.8.0
BUILD: 62994
COMMIT: 85b22d307ab93fca95c1698ede4cb61d85f3d314

Browser Details
This issue is occurring on all browsers.

Preconditions

  1. Kibana must be available.
  2. Custom Rule must be present.

Steps to Reproduce

  1. Navigate to Security -> Alerts -> Manage Rule
  2. Open Rule details page.
  3. Click on Bell icon to add Snooze Schedule.
  4. Click on Add Schedule option.
  5. In Calendar, click on same date twice.
  6. Observe that Start Time and End Time will be add as same for Snooze Notifications for any rule thus creating confusion to user as if Notifications will be snoozed for that particular minute?

Actual Result
Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule

Expected Result
User should not be able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule and user prompt for this should also be there.

What's Working

  • N/A

What's Not Working

  • N/A

Screen Recording

Rules.-.Kibana.-.Google.Chrome.2023-05-16.17-04-26.mp4
@arvindersingh-qasource arvindersingh-qasource added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.0 labels May 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@arvindersingh-qasource
Copy link
Author

@karanbirsingh-qasource Please review this ticket.

Thanks.

@ghost ghost assigned MadameSheema and unassigned ghost May 16, 2023
@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team labels May 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Rule Management Security Solution Detection Rule Management area Feature:Alerting/RulesManagement Issues related to the Rules Management UX and removed triage_needed v8.8.0 labels May 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@banderror banderror removed their assignment May 25, 2023
@banderror
Copy link
Contributor

cc @elastic/response-ops-ram @XavierM

@banderror banderror changed the title [Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule [RAM][Security Solution] Able to add Same Start Time and End Time in Schedule for Snooze Notifications of Rule May 25, 2023
@gitstart gitstart mentioned this issue May 26, 2023
Merged
@XavierM XavierM moved this from Awaiting Triage to In Review in AppEx: ResponseOps - Rules & Alerts Management Jun 6, 2023
Zacqary pushed a commit that referenced this issue Jun 8, 2023
@gitstart @KlingerMatheus
[Security Solution] Able to add Same Start Time and End Time in Sched…
d9eff3f 
…ule for Snooze Notifications of Rule (#158565)

## What does this PR do?
* It doesn't allows the user to pick the same date and time in the
schedule component.

## Issue References
* Client: #157865

## Video/Screenshot Demo 

###### FIX:
https://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a

---
This code was written and reviewed by GitStart Community. Growing great
engineers, one PR at a time.

Co-authored-by: KlingerMatheus <[email protected]>
Co-authored-by: gitstart_bot <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jun 8, 2023
@gitstart
[Security Solution] Able to add Same Start Time and End Time in Sched…
90372f3 
…ule for Snooze Notifications of Rule (elastic#158565)

## What does this PR do?
* It doesn't allows the user to pick the same date and time in the
schedule component.

## Issue References
* Client: elastic#157865

## Video/Screenshot Demo

###### FIX:
https://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a

---
This code was written and reviewed by GitStart Community. Growing great
engineers, one PR at a time.

Co-authored-by: KlingerMatheus <[email protected]>
Co-authored-by: gitstart_bot <[email protected]>
(cherry picked from commit d9eff3f)
kibanamachine referenced this issue Jun 8, 2023
@kibanamachine @gitstart
[8.8] [Security Solution] Able to add Same Start Time and End Time in…
97bb42c 
… Schedule for Snooze Notifications of Rule (#158565) (#159331)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution] Able to add Same Start Time and End Time in
Schedule for Snooze Notifications of Rule
(#158565)](#158565)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"GitStart","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-08T15:57:03Z","message":"[Security
Solution] Able to add Same Start Time and End Time in Schedule for
Snooze Notifications of Rule (#158565)\n\n## What does this PR do?\r\n*
It doesn't allows the user to pick the same date and time in
the\r\nschedule component.\r\n\r\n## Issue References\r\n* Client:
https://github.com/elastic/kibana/issues/157865\r\n\r\n##
Video/Screenshot Demo \r\n\r\n######
FIX:\r\nhttps://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a\r\n\r\n---\r\nThis
code was written and reviewed by GitStart Community. Growing
great\r\nengineers, one PR at a time.\r\n\r\nCo-authored-by:
KlingerMatheus <[email protected]>\r\nCo-authored-by:
gitstart_bot
<[email protected]>","sha":"d9eff3fd84c7eb9da0f3d3e1106d6054b3a4cad7","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","v8.9.0","v8.8.2"],"number":158565,"url":"https://github.com/elastic/kibana/pull/158565","mergeCommit":{"message":"[Security
Solution] Able to add Same Start Time and End Time in Schedule for
Snooze Notifications of Rule (#158565)\n\n## What does this PR do?\r\n*
It doesn't allows the user to pick the same date and time in
the\r\nschedule component.\r\n\r\n## Issue References\r\n* Client:
https://github.com/elastic/kibana/issues/157865\r\n\r\n##
Video/Screenshot Demo \r\n\r\n######
FIX:\r\nhttps://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a\r\n\r\n---\r\nThis
code was written and reviewed by GitStart Community. Growing
great\r\nengineers, one PR at a time.\r\n\r\nCo-authored-by:
KlingerMatheus <[email protected]>\r\nCo-authored-by:
gitstart_bot
<[email protected]>","sha":"d9eff3fd84c7eb9da0f3d3e1106d6054b3a4cad7"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158565","number":158565,"mergeCommit":{"message":"[Security
Solution] Able to add Same Start Time and End Time in Schedule for
Snooze Notifications of Rule (#158565)\n\n## What does this PR do?\r\n*
It doesn't allows the user to pick the same date and time in
the\r\nschedule component.\r\n\r\n## Issue References\r\n* Client:
https://github.com/elastic/kibana/issues/157865\r\n\r\n##
Video/Screenshot Demo \r\n\r\n######
FIX:\r\nhttps://www.loom.com/share/fc4a43eba71f485384621ecec457ce1a\r\n\r\n---\r\nThis
code was written and reviewed by GitStart Community. Growing
great\r\nengineers, one PR at a time.\r\n\r\nCo-authored-by:
KlingerMatheus <[email protected]>\r\nCo-authored-by:
gitstart_bot
<[email protected]>","sha":"d9eff3fd84c7eb9da0f3d3e1106d6054b3a4cad7"}},{"branch":"8.8","label":"v8.8.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: GitStart <[email protected]>
@XavierM XavierM closed this as completed Jun 14, 2023
@banderror
Copy link
Contributor

@arvindersingh-qasource The issue should be fixed in 8.8.2, could you please verify the fix when the first BC is ready?

@banderror banderror reopened this Jun 14, 2023
@arvindersingh-qasource
Copy link
Author

Hi @banderror

Thanks for the update.

We have validated this issue with Kibana v8.8.2 and found that now on clicking the same date twice under Add Schedule create a Snooze Time for 1 minute.

Please find the below observations

Build Details

VERSION: 8.8.2
BUILD: 63328
COMMIT: db8521641e9f4c545859a80e19f34066c507a137

Observations

Rules.-.Kibana.-.Google.Chrome.2023-06-23.13-13-26.mp4

Hence, we are closing this ticket.

Thanks.

@arvindersingh-qasource arvindersingh-qasource added the QA:Validated Issue has been validated by QA label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesManagement Issues related to the Rules Management UX Feature:Rule Management Security Solution Detection Rule Management area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.8.2
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@XavierM @Zacqary @banderror @elasticmachine @MadameSheema @arvindersingh-qasource