Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Remove forced actions from detection rules Cypress tests #158560

Merged
merged 2 commits into from
May 30, 2023
Merged

[Security Solution] Remove forced actions from detection rules Cypress tests #158560

merged 2 commits into from
May 30, 2023

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented May 26, 2023

Relates to: #152344, #152470
Depends on: #158392

Summary

Removes force option from Cypress actions like type(), click() and etc. It helps to catch UI quirks instead of silently ignoring them.

Details

After merging back of #158392 it's possible to remove force: true flag from the Cypress actions used in Detection rules tests. Based on the discussion in #152470 it's bette to avoid forced actions and leave a comment if there is no other way than forcing an action.

@maximpn maximpn added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team v8.9.0 labels May 26, 2023
@maximpn maximpn self-assigned this May 26, 2023
@maximpn maximpn marked this pull request as ready for review May 27, 2023 08:06
@maximpn maximpn requested a review from a team as a code owner May 27, 2023 08:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@maximpn maximpn mentioned this pull request May 27, 2023
Closed
@maximpn maximpn requested review from a team as code owners May 27, 2023 08:36
@maximpn maximpn requested a review from dplumlee May 27, 2023 08:36
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

@maximpn maximpn requested a review from xcrzx May 27, 2023 10:17
@maximpn maximpn merged commit 0d3b63b into elastic:main May 30, 2023
@maximpn maximpn deleted the remove-force-true branch May 30, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplumlee dplumlee dplumlee approved these changes

@xcrzx xcrzx Awaiting requested review from xcrzx

Assignees

@maximpn maximpn

Labels
backport:skip This commit does not require backporting Feature:Rule Management Security Solution Detection Rule Management area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximpn @elasticmachine @kibana-ci @dplumlee