[Security Solution] [Timeline] Remove code added to workaround an eui issue, causing focus issues #158392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqualters-elastic
added
release_note:skip
maximpn
approved these changes
May 24, 2023
There was a problem hiding this comment.
@kqualters-elastic thank you for addressing #152344 and removing unnecessary anymore code 🎉
I've tested it locally and tried to run Cypress tests without force: true option in type() command and it works as expected.
michaelolo24
approved these changes
May 24, 2023
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
This was referenced May 26, 2023
maximpn
added a commit
that referenced
this pull request
May 30, 2023
…s tests (#158560) **Relates to:** #152344, #152470 **Depends on:** #158392 ## Summary Removes `force` option from Cypress actions like `type()`, `click()` and etc. It helps to catch UI quirks instead of silently ignoring them. ## Details After merging back of #158392 it's possible to remove `force: true` flag from the Cypress actions used in Detection rules tests. Based on the discussion in #152470 it's bette to avoid forced actions and leave a comment if there is no other way than forcing an action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr removes some code added 2 years ago to work around an eui issue with the global search bar and timeline focus, was causing issues in some cases, like in #152344 none of this code is needed, as the original bug no longer exists.
Checklist