-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Use license management locator #158278
[APM] Use license management locator #158278
Conversation
19ad09a
to
eea4770
Compare
eea4770
to
c2472bc
Compare
Pinging @elastic/apm-ui (Team:APM) |
3827f83
to
7ee2069
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
x-pack/plugins/apm/public/context/license/invalid_license_notification.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌴
? licenseManagement?.locator?.useUrl({ | ||
page: 'dashboard', | ||
}) | ||
: licensePageUrl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @sqren,
We talk about what will happen if licenseManagement.locator
is undefined, but I'm actually not sure if we want to fall back to the licensePageUrl = '/app/management/stack/license_management'
what else we can do in this case? any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the case where license management plugin is disabled we don't want to link to the license page, because it'll display a 404. In that case I think we can just not show the link.
That being said, I don't think this will ever happen. If the license management is not enabled, the user ought to have something like an enterprise license, with access to everything.
Closes #153014