Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Check is License Management is enabled when linking to it #153014

Closed
yuliacech opened this issue Mar 9, 2023 · 5 comments · Fixed by #158278
Closed

[APM] Check is License Management is enabled when linking to it #153014

yuliacech opened this issue Mar 9, 2023 · 5 comments · Fixed by #158278
Assignees
Labels
8.9 candidate apm:release-feature APM UI - Release Feature Goal apm:serverless apm:test-plan-done Pull request that was successfully tested during the test plan Feature:License Team:APM All issues that need APM UI Team support Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

yuliacech commented Mar 9, 2023

The APM plugin has a License Prompt component and an Invalid License notification that link to the License Management plugin.

We are adding a config that would allow disabling the License Management plugin, so this link might lead to a Not Found route in Kibana in that case.

@yuliacech yuliacech added Team:APM All issues that need APM UI Team support Feature:License Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Mar 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@sorenlouv
Copy link
Member

sorenlouv commented Mar 9, 2023

We are adding a config that would allow disabling the License Management plugin, so this link might lead to a Not Found route in Kibana in that case.

@yuliacech Didn't we decide a while back to enable all plugins to avoid the complexity optional plugins comes with?

Just to close the loop here for clarity: with these changes, none of the plugins that ship with Kibana will be disable-able starting in 8.0, with the exception of the following:

@yuliacech
Copy link
Contributor Author

Yes, that is correct @sqren, but for serverless we might want to make some plugins disable-able again but in a very limited combination. So we wanted to document any "hidden"/implicit dependencies on License Management for now.

The problem with the links still needs to be addressed at some point though, because License Management currently can be hidden from UI completely with ui.enabled: false. In that case the link would still lead to a Not Found in Kibana.

I think a recommended way to (deep)link to other plugins would be a URL locator. I will open an issue to add one for License Management that can later be used by the APM plugin.

@gbamparop
Copy link
Contributor

Here's an example of the usage in the watcher plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.9 candidate apm:release-feature APM UI - Release Feature Goal apm:serverless apm:test-plan-done Pull request that was successfully tested during the test plan Feature:License Team:APM All issues that need APM UI Team support Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants