[8.7] [packages] migrate all plugins to packages (#148130) #157306

mistic · 2023-05-10T17:33:47Z

Backport

This will backport the following commits from main to 8.7:

[packages] migrate all plugins to packages (#148130)

Questions ?

Please refer to the Backport tool documentation

Fixes elastic#149344 This PR migrates all plugins to packages automatically. It does this using `node scripts/lint_packages` to automatically migrate `kibana.json` files to `kibana.jsonc` files. By doing this automatically we can simplify many build and testing procedures to only support packages, and not both "packages" and "synthetic packages" (basically pointers to plugins). The majority of changes are in operations related code, so we'll be having operations review this before marking it ready for review. The vast majority of the code owners are simply pinged because we deleted all `kibana.json` files and replaced them with `kibana.jsonc` files, so we plan on leaving the PR ready-for-review for about 24 hours before merging (after feature freeze), assuming we don't have any blockers (especially from @elastic/kibana-core since there are a few core specific changes, though the majority were handled in elastic#149370). --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 1b85815) # Conflicts: # .github/CODEOWNERS # src/dev/build/tasks/bundle_fleet_packages.ts # src/dev/tsconfig.json # yarn.lock

kibana-ci · 2023-05-11T00:34:13Z

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

[job] [logs] Threat Intelligence Tests #4 / Block list interactions add to blocklist flyout should have the correct IoC id
[job] [logs] Threat Intelligence Tests #4 / Block list interactions add to blocklist flyout should have the correct IoC id
[job] [logs] Threat Intelligence Tests #3 / Indicators Indicators timeline interactions should add entry in timeline when clicking in an indicator flyout overview block
[job] [logs] Threat Intelligence Tests #4 / Indicators Indicators timeline interactions should add entry in timeline when clicking in an indicator flyout overview block
[job] [logs] Threat Intelligence Tests #4 / Indicators Indicators timeline interactions should add entry in timeline when clicking in an indicator flyout overview tab table row
[job] [logs] Security Solution Tests #4 / Timeline search and filters Update kqlMode for timeline "before each" hook for "should be able to update timeline kqlMode with filter"
[job] [logs] Security Solution Tests #4 / Timeline search and filters Update kqlMode for timeline "before each" hook for "should be able to update timeline kqlMode with search"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/chart-expressions-common`	-	4	+4
`@kbn/import-resolver`	39	40	+1
`@kbn/json-ast`	28	35	+7
`@kbn/test`	225	227	+2
`@kbn/ts-projects`	26	25	-1
total			+13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	753.0KB	753.0KB	-5.0B
`apm`	3.3MB	3.3MB	-26.0B
`canvas`	1.0MB	1.0MB	-18.0B
`cases`	365.2KB	365.2KB	-2.0B
`cloudChat`	2.8KB	2.8KB	-1.0B
`cloudDataMigration`	3.6KB	3.6KB	-1.0B
`cloudDefend`	223.8KB	223.8KB	-3.0B
`cloudExperiments`	40.5KB	40.5KB	-1.0B
`cloudFullStory`	4.3KB	4.3KB	-1.0B
`cloudGainsight`	2.1KB	2.1KB	-1.0B
`cloudSecurityPosture`	145.2KB	145.2KB	-3.0B
`crossClusterReplication`	166.5KB	166.5KB	-1.0B
`dataVisualizer`	380.8KB	380.8KB	-5.0B
`enterpriseSearch`	2.2MB	2.1MB	-15.0B
`fileUpload`	852.2KB	852.2KB	-1.0B
`fleet`	930.9KB	930.9KB	-7.0B
`graph`	450.8KB	450.8KB	-3.0B
`grokdebugger`	59.1KB	59.1KB	-1.0B
`indexLifecycleManagement`	156.2KB	156.2KB	-1.0B
`indexManagement`	522.3KB	522.3KB	-1.0B
`infra`	1.3MB	1.3MB	-19.0B
`ingestPipelines`	431.2KB	431.2KB	-1.0B
`kubernetesSecurity`	39.6KB	39.6KB	-1.0B
`lens`	1.3MB	1.3MB	-15.0B
`licenseManagement`	62.9KB	62.9KB	-1.0B
`lists`	156.4KB	156.4KB	-1.0B
`logstash`	30.6KB	30.6KB	-1.0B
`maps`	2.7MB	2.7MB	-15.0B
`ml`	3.4MB	3.4MB	-32.0B
`monitoring`	455.5KB	455.5KB	-5.0B
`observability`	585.4KB	585.4KB	-19.0B
`osquery`	1.1MB	1.1MB	-10.0B
`painlessLab`	16.1KB	16.1KB	-1.0B
`profiling`	258.8KB	258.8KB	-1.0B
`remoteClusters`	84.9KB	84.9KB	-1.0B
`reporting`	58.8KB	58.8KB	-4.0B
`rollup`	131.2KB	131.2KB	-1.0B
`savedObjectsTagging`	40.8KB	40.8KB	-4.0B
`searchprofiler`	159.0KB	159.0KB	-1.0B
`security`	556.9KB	556.8KB	-21.0B
`securitySolution`	13.9MB	13.9MB	+132.0B
`sessionView`	382.9KB	382.9KB	-1.0B
`snapshotRestore`	267.4KB	267.4KB	-1.0B
`spaces`	174.1KB	174.1KB	-11.0B
`stackAlerts`	80.3KB	80.3KB	-3.0B
`stackConnectors`	419.5KB	419.4KB	-62.0B
`synthetics`	1.4MB	1.4MB	-24.0B
`threatIntelligence`	52.5KB	52.5KB	-3.0B
`timelines`	30.0KB	30.0KB	-8.0B
`transform`	368.3KB	368.3KB	-3.0B
`triggersActionsUi`	759.4KB	759.4KB	-58.0B
`upgradeAssistant`	149.9KB	149.9KB	-1.0B
`ux`	160.4KB	160.4KB	-3.0B
`watcher`	271.6KB	271.6KB	-2.0B
total			-299.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/core`	-	1	+1
`@kbn/repo-packages`	3	2	-1
total			-0

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`actions`	15.6KB	15.6KB	-1.0B
`aiops`	5.3KB	5.3KB	-1.0B
`alerting`	41.0KB	41.0KB	-1.0B
`apm`	32.1KB	32.1KB	-1.0B
`banners`	6.5KB	6.5KB	-1.0B
`canvas`	13.3KB	13.3KB	-1.0B
`cases`	130.1KB	130.1KB	-1.0B
`cloud`	3.4KB	3.4KB	-1.0B
`cloudChat`	4.9KB	4.9KB	-1.0B
`cloudDataMigration`	4.4KB	4.4KB	-1.0B
`cloudDefend`	3.6KB	3.6KB	-1.0B
`cloudExperiments`	10.0KB	10.0KB	-1.0B
`cloudFullStory`	3.4KB	3.4KB	-1.0B
`cloudGainsight`	3.5KB	3.5KB	-1.0B
`cloudLinks`	3.0KB	3.0KB	-1.0B
`cloudSecurityPosture`	10.9KB	10.9KB	-1.0B
`crossClusterReplication`	11.9KB	11.9KB	-1.0B
`customBranding`	1.5KB	1.5KB	-1.0B
`dashboardEnhanced`	15.3KB	15.3KB	-1.0B
`dataVisualizer`	25.5KB	25.5KB	-1.0B
`discoverEnhanced`	5.9KB	5.9KB	-1.0B
`embeddableEnhanced`	6.7KB	6.7KB	-1.0B
`enterpriseSearch`	29.8KB	29.8KB	-1.0B
`features`	3.6KB	3.6KB	-1.0B
`fileUpload`	7.2KB	7.2KB	-1.0B
`fleet`	124.7KB	124.7KB	-1.0B
`globalSearch`	6.3KB	6.3KB	-1.0B
`globalSearchBar`	20.5KB	20.5KB	-1.0B
`globalSearchProviders`	4.6KB	4.6KB	-1.0B
`graph`	7.4KB	7.4KB	-1.0B
`grokdebugger`	4.5KB	4.5KB	-1.0B
`indexLifecycleManagement`	26.9KB	26.9KB	-1.0B
`indexManagement`	27.1KB	27.1KB	-1.0B
`infra`	87.2KB	87.2KB	-1.0B
`ingestPipelines`	13.5KB	13.5KB	-1.0B
`kubernetesSecurity`	3.7KB	3.7KB	-1.0B
`lens`	34.0KB	34.0KB	-1.0B
`licenseManagement`	10.2KB	10.2KB	-1.0B
`licensing`	9.1KB	9.1KB	-1.0B
`lists`	3.7KB	3.7KB	-1.0B
`logstash`	14.0KB	14.0KB	-1.0B
`maps`	53.1KB	53.1KB	-1.0B
`ml`	42.5KB	42.5KB	-1.0B
`monitoring`	24.1KB	24.1KB	-1.0B
`observability`	84.0KB	84.0KB	-1.0B
`osquery`	50.4KB	50.4KB	-1.0B
`painlessLab`	10.3KB	10.3KB	-1.0B
`profiling`	13.7KB	13.7KB	-1.0B
`remoteClusters`	7.8KB	7.8KB	-1.0B
`reporting`	42.5KB	42.5KB	-1.0B
`rollup`	11.6KB	11.6KB	-1.0B
`runtimeFields`	11.0KB	11.0KB	-1.0B
`savedObjectsTagging`	19.0KB	19.0KB	-1.0B
`screenshotting`	7.9KB	7.9KB	-1.0B
`searchprofiler`	19.8KB	19.8KB	-1.0B
`security`	58.0KB	58.0KB	-1.0B
`securitySolution`	52.8KB	52.8KB	-1.0B
`sessionView`	5.7KB	5.7KB	-1.0B
`snapshotRestore`	27.5KB	27.5KB	-1.0B
`spaces`	20.4KB	20.4KB	-1.0B
`stackAlerts`	15.6KB	15.6KB	-1.0B
`stackConnectors`	28.0KB	28.0KB	-1.0B
`synthetics`	27.0KB	27.0KB	-1.0B
`threatIntelligence`	31.3KB	31.3KB	-1.0B
`timelines`	87.1KB	87.1KB	-1.0B
`transform`	16.8KB	16.8KB	-1.0B
`triggersActionsUi`	123.5KB	123.5KB	-1.0B
`upgradeAssistant`	19.4KB	19.4KB	-1.0B
`urlDrilldown`	15.4KB	15.4KB	-1.0B
`ux`	5.9KB	5.9KB	-1.0B
`visTypeGauge`	12.1KB	12.1KB	-6.0B
`visTypeHeatmap`	12.6KB	12.6KB	-6.0B
`visTypePie`	10.3KB	10.3KB	-6.0B
`visTypeVislib`	12.8KB	12.8KB	-12.0B
`visTypeXy`	31.1KB	31.1KB	-6.0B
`watcher`	13.4KB	13.4KB	-1.0B
total			-107.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/chart-expressions-common`	-	4	+4
`@kbn/get-repo-files`	6	0	-6
`@kbn/json-ast`	32	41	+9
`@kbn/test`	269	271	+2
total			+9

ESLint disabled in files

id	before	after	diff
`@kbn/core`	-	1	+1
`dataViews`	2	1	-1
`observability`	7	6	-1
`ux`	3	2	-1
total			-2

ESLint disabled line counts

id	before	after	diff
`@kbn/core`	-	7	+7
`@kbn/optimizer`	3	1	-2
`esUiShared`	12	11	-1
total			+4

References to deprecated APIs

id	before	after	diff
`@kbn/core`	-	37	+37
`@kbn/core-application-browser-internal`	2	1	-1
`@kbn/core-application-browser-mocks`	2	1	-1
`@kbn/core-elasticsearch-server-internal`	4	2	-2
`@kbn/core-lifecycle-browser`	6	2	-4
`@kbn/core-plugins-browser-internal`	8	5	-3
`@kbn/core-plugins-server`	3	0	-3
`@kbn/core-plugins-server-internal`	20	10	-10
`@kbn/core-root-browser-internal`	5	4	-1
`@kbn/core-saved-objects-api-browser`	137	54	-83
`@kbn/core-saved-objects-api-server`	89	67	-22
`@kbn/core-saved-objects-browser`	6	2	-4
`@kbn/core-saved-objects-browser-internal`	393	238	-155
`@kbn/core-saved-objects-browser-mocks`	55	32	-23
`@kbn/core-saved-objects-common`	14	6	-8
`@kbn/core-saved-objects-import-export-server-internal`	70	56	-14
`@kbn/core-saved-objects-migration-server-internal`	44	22	-22
`@kbn/core-saved-objects-server`	16	12	-4
`@kbn/core-saved-objects-server-internal`	4	2	-2
`@kbn/core-test-helpers-so-type-serializer`	8	4	-4
`@kbn/core-ui-settings-server-internal`	15	12	-3
`@kbn/eslint-plugin-imports`	1	0	-1
`@kbn/find-used-node-modules`	3	0	-3
`@kbn/repo-source-classifier`	1	0	-1
`actions`	37	22	-15
`advancedSettings`	7	3	-4
`aiops`	9	7	-2
`alerting`	71	46	-25
`apm`	39	38	-1
`canvas`	183	147	-36
`cases`	154	104	-50
`cloudSecurityPosture`	17	9	-8
`console`	2	1	-1
`controls`	39	27	-12
`dashboard`	141	74	-67
`dashboardEnhanced`	18	9	-9
`data`	151	114	-37
`dataViews`	204	148	-56
`dataVisualizer`	21	18	-3
`discover`	57	43	-14
`embeddable`	39	23	-16
`encryptedSavedObjects`	6	4	-2
`enterpriseSearch`	13	10	-3
`expressions`	26	13	-13
`fileUpload`	2	1	-1
`fleet`	79	61	-18
`globalSearchProviders`	4	2	-2
`graph`	128	86	-42
`home`	41	34	-7
`infra`	174	110	-64
`kibanaOverview`	8	7	-1
`kibanaUtils`	10	5	-5
`lens`	210	110	-100
`lists`	99	93	-6
`management`	2	1	-1
`maps`	67	41	-26
`ml`	191	164	-27
`monitoring`	6	4	-2
`observability`	70	66	-4
`osquery`	53	41	-12
`presentationUtil`	17	12	-5
`savedObjects`	234	121	-113
`savedObjectsFinder`	41	24	-17
`savedObjectsManagement`	43	35	-8
`savedObjectsTagging`	110	75	-35
`savedObjectsTaggingOss`	44	29	-15
`savedSearch`	74	36	-38
`security`	65	64	-1
`securitySolution`	389	357	-32
`spaces`	17	13	-4
`synthetics`	152	109	-43
`taskManager`	4	2	-2
`transform`	34	29	-5
`triggersActionsUi`	11	8	-3
`uiActionsEnhanced`	20	10	-10
`unifiedSearch`	27	25	-2
`upgradeAssistant`	22	20	-2
`visTypeTimeseries`	74	72	-2
`visualizations`	276	136	-140
`watcher`	14	8	-6
total			-1512

Total ESLint disabled count

id	before	after	diff
`@kbn/core`	-	8	+8
`@kbn/optimizer`	5	3	-2
`dataViews`	14	13	-1
`esUiShared`	12	11	-1
`observability`	61	60	-1
`ux`	12	11	-1
total			+2

History

💔 Build #126942 failed 4ab097e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic added the backport label May 10, 2023

mistic enabled auto-merge (squash) May 10, 2023 17:33

mistic mentioned this pull request May 10, 2023

[packages] migrate all plugins to packages #148130

Merged

fix(NA): build config params

6c254df

mistic merged commit 2dfd1b3 into elastic:8.7 May 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.7] [packages] migrate all plugins to packages (#148130) #157306

[8.7] [packages] migrate all plugins to packages (#148130) #157306

mistic commented May 10, 2023

kibana-ci commented May 11, 2023 •

edited

Loading

API count

ESLint disabled in files

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

[8.7] [packages] migrate all plugins to packages (#148130) #157306

[8.7] [packages] migrate all plugins to packages (#148130) #157306

Conversation

mistic commented May 10, 2023

Backport

Questions ?

kibana-ci commented May 11, 2023 • edited Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

ESLint disabled in files

ESLint disabled line counts

References to deprecated APIs

Total ESLint disabled count

History

kibana-ci commented May 11, 2023 •

edited

Loading