[packages] migrate all plugins to packages #148130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
implement/plugins-are-packages
branch
from
05b9748 to
6bb0b83
Compare
spalger
force-pushed
the
implement/plugins-are-packages
branch
from
d10d1c4 to
edb4a7e
Compare
spalger
force-pushed
the
implement/plugins-are-packages
branch
from
ed2e449 to
17555ec
Compare
spalger
force-pushed
the
implement/plugins-are-packages
branch
20 times, most recently
from
2bcf1b3 to
687cefa
Compare
spalger
force-pushed
the
implement/plugins-are-packages
branch
3 times, most recently
from
8b6215c to
c3758da
Compare
spalger
force-pushed
the
implement/plugins-are-packages
branch
from
eadda8e to
436df62
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Adoption-tracked APIs
Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.8.0
backport:skip
|
@spalger I'm using the latest version of kibana because of the added metrics features. I wanted to create a new visualization type for a very edge case. I tried to do it using the plugin generator but than realized that the file extension should be corrected. Unfortunately, after that the application stops working. I started a thread on it here |
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
May 10, 2023
Fixes elastic#149344 This PR migrates all plugins to packages automatically. It does this using `node scripts/lint_packages` to automatically migrate `kibana.json` files to `kibana.jsonc` files. By doing this automatically we can simplify many build and testing procedures to only support packages, and not both "packages" and "synthetic packages" (basically pointers to plugins). The majority of changes are in operations related code, so we'll be having operations review this before marking it ready for review. The vast majority of the code owners are simply pinged because we deleted all `kibana.json` files and replaced them with `kibana.jsonc` files, so we plan on leaving the PR ready-for-review for about 24 hours before merging (after feature freeze), assuming we don't have any blockers (especially from @elastic/kibana-core since there are a few core specific changes, though the majority were handled in elastic#149370). --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 1b85815) # Conflicts: # .github/CODEOWNERS # src/dev/build/tasks/bundle_fleet_packages.ts # src/dev/tsconfig.json # yarn.lock
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mistic
added a commit
that referenced
this pull request
May 11, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [[packages] migrate all plugins to packages (#148130)](#148130) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Spencer","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-09T03:06:50Z","message":"[packages] migrate all plugins to packages (#148130)\n\nFixes https://github.com/elastic/kibana/issues/149344\r\n\r\nThis PR migrates all plugins to packages automatically. It does this\r\nusing `node scripts/lint_packages` to automatically migrate\r\n`kibana.json` files to `kibana.jsonc` files. By doing this automatically\r\nwe can simplify many build and testing procedures to only support\r\npackages, and not both \"packages\" and \"synthetic packages\" (basically\r\npointers to plugins).\r\n\r\nThe majority of changes are in operations related code, so we'll be\r\nhaving operations review this before marking it ready for review. The\r\nvast majority of the code owners are simply pinged because we deleted\r\nall `kibana.json` files and replaced them with `kibana.jsonc` files, so\r\nwe plan on leaving the PR ready-for-review for about 24 hours before\r\nmerging (after feature freeze), assuming we don't have any blockers\r\n(especially from @elastic/kibana-core since there are a few core\r\nspecific changes, though the majority were handled in #149370).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"1b8581540295fde746dae6b4a09d74fb5821bfef","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:skip","v8.8.0"],"number":148130,"url":"https://github.com/elastic/kibana/pull/148130","mergeCommit":{"message":"[packages] migrate all plugins to packages (#148130)\n\nFixes https://github.com/elastic/kibana/issues/149344\r\n\r\nThis PR migrates all plugins to packages automatically. It does this\r\nusing `node scripts/lint_packages` to automatically migrate\r\n`kibana.json` files to `kibana.jsonc` files. By doing this automatically\r\nwe can simplify many build and testing procedures to only support\r\npackages, and not both \"packages\" and \"synthetic packages\" (basically\r\npointers to plugins).\r\n\r\nThe majority of changes are in operations related code, so we'll be\r\nhaving operations review this before marking it ready for review. The\r\nvast majority of the code owners are simply pinged because we deleted\r\nall `kibana.json` files and replaced them with `kibana.jsonc` files, so\r\nwe plan on leaving the PR ready-for-review for about 24 hours before\r\nmerging (after feature freeze), assuming we don't have any blockers\r\n(especially from @elastic/kibana-core since there are a few core\r\nspecific changes, though the majority were handled in #149370).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"1b8581540295fde746dae6b4a09d74fb5821bfef"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148130","number":148130,"mergeCommit":{"message":"[packages] migrate all plugins to packages (#148130)\n\nFixes https://github.com/elastic/kibana/issues/149344\r\n\r\nThis PR migrates all plugins to packages automatically. It does this\r\nusing `node scripts/lint_packages` to automatically migrate\r\n`kibana.json` files to `kibana.jsonc` files. By doing this automatically\r\nwe can simplify many build and testing procedures to only support\r\npackages, and not both \"packages\" and \"synthetic packages\" (basically\r\npointers to plugins).\r\n\r\nThe majority of changes are in operations related code, so we'll be\r\nhaving operations review this before marking it ready for review. The\r\nvast majority of the code owners are simply pinged because we deleted\r\nall `kibana.json` files and replaced them with `kibana.jsonc` files, so\r\nwe plan on leaving the PR ready-for-review for about 24 hours before\r\nmerging (after feature freeze), assuming we don't have any blockers\r\n(especially from @elastic/kibana-core since there are a few core\r\nspecific changes, though the majority were handled in #149370).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"1b8581540295fde746dae6b4a09d74fb5821bfef"}}]}] BACKPORT--> --------- Co-authored-by: Spencer <[email protected]>
jgowdyelastic
added a commit
that referenced
this pull request
Jul 31, 2024
The ML team should be a code owner of the file upload plugin. This [PR](#148130) removed them by accident while removing duplicate entries. --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149344
This PR migrates all plugins to packages automatically. It does this using
node scripts/lint_packagesto automatically migratekibana.jsonfiles tokibana.jsoncfiles. By doing this automatically we can simplify many build and testing procedures to only support packages, and not both "packages" and "synthetic packages" (basically pointers to plugins).The majority of changes are in operations related code, so we'll be having operations review this before marking it ready for review. The vast majority of the code owners are simply pinged because we deleted all
kibana.jsonfiles and replaced them withkibana.jsoncfiles, so we plan on leaving the PR ready-for-review for about 24 hours before merging (after feature freeze), assuming we don't have any blockers (especially from @elastic/kibana-core since there are a few core specific changes, though the majority were handled in #149370).