Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM][Maintenance Window] Improve Maintenance Window Backend Integration Testing #157120

Merged
merged 8 commits into from
May 16, 2023

Conversation

JiaweiWu
Copy link
Contributor

@JiaweiWu JiaweiWu commented May 9, 2023

Summary

Resolves: #155902

Improves backend integration testing for maintenance windows, tests the following:

API:

  • Add more tests around create/update, ensuring events are generated correctly
  • Add more tests around /_active, ensuring the query we use is solid
  • Add more tests around cancelling/archiving
  • Verify functionality of the 3 MW scenarios
  • Verify summarized actions and security rules function correctly

Checklist

@JiaweiWu JiaweiWu added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.9.0 labels May 9, 2023
@JiaweiWu JiaweiWu requested a review from a team as a code owner May 9, 2023 03:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@JiaweiWu
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 400 404 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 480 484 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JiaweiWu JiaweiWu merged commit 9910615 into elastic:main May 16, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2023
jasonrhodes pushed a commit that referenced this pull request May 17, 2023
…ion Testing (#157120)

## Summary
Resolves: #155902

Improves backend integration testing for maintenance windows, tests the
following:

# API:
- Add more tests around create/update, ensuring events are generated
correctly
- Add more tests around `/_active`, ensuring the query we use is solid
- Add more tests around cancelling/archiving
- Verify functionality of the 3 MW scenarios
- Verify summarized actions and security rules function correctly

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RAM][Maintenance window] Add and improve E2E tests for the maintenance window feature
5 participants