Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM][Maintenance window] Add and improve E2E tests for the maintenance window feature #155902

Closed
10 of 14 tasks
JiaweiWu opened this issue Apr 26, 2023 · 1 comment · Fixed by #157120
Closed
10 of 14 tasks

[RAM][Maintenance window] Add and improve E2E tests for the maintenance window feature #155902

JiaweiWu opened this issue Apr 26, 2023 · 1 comment · Fixed by #157120
Assignees
@JiaweiWu @doakalexi
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.9.0

Comments

@JiaweiWu
Copy link
Contributor

JiaweiWu commented Apr 26, 2023 •
edited
Loading

Parent issue: #152032

We should add some functional tests to test the end-to-end functionality of the maintenance window feature, focusing on the major user stories.

Using the UI:

Maintenance window form: (Alexi)

  • Create a maintenance window (Testing different RRule schedules)
  • Edit a maintenance window (Testing different RRule schedules)
  • Archive a maintenance window

Maintenance window table: (Alexi)

  • Delete a maintenance window
  • Cancel a maintenance window
  • Archiving a maintenance window
  • Cancelling and archiving a maintenance window
  • Searching/filtering/pagination
  • Ensuring the table is correctly displaying the maintenance window's status

API:

  • Add more tests around create/update, ensuring events are generated correctly
  • Add more tests around /_active, ensuring the query we use is solid
  • Add more tests around cancelling/archiving
  • Verify functionality of the 3 MW scenarios
  • Verify summarized actions and security rules function correctly
@JiaweiWu JiaweiWu added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.8.0 labels Apr 26, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@JiaweiWu JiaweiWu moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Apr 26, 2023
@JiaweiWu JiaweiWu changed the title [RAM][Maintenance window] Add E2E testing to maintenance window feature [RAM][Maintenance window] Add and improve E2E testing to maintenance window feature Apr 26, 2023
@JiaweiWu JiaweiWu changed the title [RAM][Maintenance window] Add and improve E2E testing to maintenance window feature [RAM][Maintenance window] Add and improve E2E tests for the maintenance window feature Apr 26, 2023
@doakalexi doakalexi mentioned this issue May 3, 2023
Merged
@doakalexi doakalexi moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Execution & Connectors May 4, 2023
doakalexi added a commit that referenced this issue May 5, 2023
@doakalexi
[ResponseOps][Maintenance Window] Add and improve E2E tests for the m…
3fef5e5 
…aintenance window table (#156611)

## Summary

Adds functional tests for the maintenance windows table.

Should test:
-  Cancel a maintenance window
- Archiving/Unarchiving a maintenance window
- Cancelling and archiving a maintenance window
- Searching/filtering


Issue linked - #155902
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 5, 2023
@doakalexi
[ResponseOps][Maintenance Window] Add and improve E2E tests for the m…
17b06bd 
…aintenance window table (elastic#156611)

## Summary

Adds functional tests for the maintenance windows table.

Should test:
-  Cancel a maintenance window
- Archiving/Unarchiving a maintenance window
- Cancelling and archiving a maintenance window
- Searching/filtering

Issue linked - elastic#155902

(cherry picked from commit 3fef5e5)
kibanamachine referenced this issue May 5, 2023
@kibanamachine @doakalexi
[8.8] [ResponseOps][Maintenance Window] Add and improve E2E tests for…
772c00c 
… the maintenance window table (#156611) (#156853)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[ResponseOps][Maintenance Window] Add and improve E2E tests for the
maintenance window table
(#156611)](#156611)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexi
Doak","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-05T12:47:40Z","message":"[ResponseOps][Maintenance
Window] Add and improve E2E tests for the maintenance window table
(#156611)\n\n## Summary\r\n\r\nAdds functional tests for the maintenance
windows table.\r\n\r\nShould test:\r\n- Cancel a maintenance window\r\n-
Archiving/Unarchiving a maintenance window\r\n- Cancelling and archiving
a maintenance window\r\n- Searching/filtering\r\n\r\n\r\nIssue linked -
https://github.com/elastic/kibana/issues/155902","sha":"3fef5e5cda748c11786cfe66f69644b56841d656","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v8.8.0","v8.9.0"],"number":156611,"url":"https://github.com/elastic/kibana/pull/156611","mergeCommit":{"message":"[ResponseOps][Maintenance
Window] Add and improve E2E tests for the maintenance window table
(#156611)\n\n## Summary\r\n\r\nAdds functional tests for the maintenance
windows table.\r\n\r\nShould test:\r\n- Cancel a maintenance window\r\n-
Archiving/Unarchiving a maintenance window\r\n- Cancelling and archiving
a maintenance window\r\n- Searching/filtering\r\n\r\n\r\nIssue linked -
https://github.com/elastic/kibana/issues/155902","sha":"3fef5e5cda748c11786cfe66f69644b56841d656"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156611","number":156611,"mergeCommit":{"message":"[ResponseOps][Maintenance
Window] Add and improve E2E tests for the maintenance window table
(#156611)\n\n## Summary\r\n\r\nAdds functional tests for the maintenance
windows table.\r\n\r\nShould test:\r\n- Cancel a maintenance window\r\n-
Archiving/Unarchiving a maintenance window\r\n- Cancelling and archiving
a maintenance window\r\n- Searching/filtering\r\n\r\n\r\nIssue linked -
https://github.com/elastic/kibana/issues/155902","sha":"3fef5e5cda748c11786cfe66f69644b56841d656"}}]}]
BACKPORT-->

Co-authored-by: Alexi Doak <[email protected]>
@JiaweiWu JiaweiWu mentioned this issue May 9, 2023
Merged
1 task
@JiaweiWu JiaweiWu added v8.9.0 and removed v8.8.0 labels May 9, 2023
JiaweiWu added a commit that referenced this issue May 16, 2023
@JiaweiWu @kibanamachine
[RAM][Maintenance Window] Improve Maintenance Window Backend Integrat…
9910615 
…ion Testing (#157120)

## Summary
Resolves: #155902

Improves backend integration testing for maintenance windows, tests the
following:

# API:
- Add more tests around create/update, ensuring events are generated
correctly
- Add more tests around `/_active`, ensuring the query we use is solid
- Add more tests around cancelling/archiving
- Verify functionality of the 3 MW scenarios
- Verify summarized actions and security rules function correctly

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <[email protected]>
jasonrhodes pushed a commit that referenced this issue May 17, 2023
@JiaweiWu @kibanamachine @jasonrhodes
[RAM][Maintenance Window] Improve Maintenance Window Backend Integrat…
e1ebf6d 
…ion Testing (#157120)

## Summary
Resolves: #155902

Improves backend integration testing for maintenance windows, tests the
following:

# API:
- Add more tests around create/update, ensuring events are generated
correctly
- Add more tests around `/_active`, ensuring the query we use is solid
- Add more tests around cancelling/archiving
- Verify functionality of the 3 MW scenarios
- Verify summarized actions and security rules function correctly

### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaweiWu JiaweiWu

@doakalexi doakalexi

Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.9.0
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Status: Done
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM][Maintenance Window] Improve Maintenance Window Backend Integration Testing JiaweiWu/kibana
3 participants
@elasticmachine @JiaweiWu @doakalexi