Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.7] [Reporting/Screenshotting] upgrade Puppeteer dependency to v20.1.0 (#156766) #157091

Merged
merged 5 commits into from
May 10, 2023

Conversation

tsullivan
Copy link
Member

Backport

This will backport the following commits from main to 8.7:

Questions ?

Please refer to the Backport tool documentation

…lastic#156766)

## Summary

Upgrades the dependency for capturing screenshots with Chromium to
[Puppeteer
v20.1.0](https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-v20.1.0)

We're using publicly available Chromium downloads for Windows and Mac.
For Linux, we create a custom build that doesn't have dependencies on
X11 shared libraries.

**Versions:**
* Linux: **113.0.5672.63**
* Windows: **113.0.5672.0**
* Darwin x64: **113.0.5672.0**
* Darwin arm64: **113.0.5672.0**

### Checklist

Delete any items that are not applicable to this PR.
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Verified in Cloud deployment

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 89a8ab8)

# Conflicts:
#	package.json
#	src/dev/build/tasks/install_chromium.ts
#	src/dev/chromium_version/index.ts
#	src/dev/tsconfig.json
#	x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/args.test.ts
#	x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/args.ts
#	x-pack/plugins/screenshotting/server/browsers/chromium/paths.ts
#	yarn.lock
@tsullivan tsullivan enabled auto-merge (squash) May 8, 2023 21:32
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
screenshotting 3 4 +1

Total ESLint disabled count

id before after diff
screenshotting 9 10 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 58a895f into elastic:8.7 May 10, 2023
tsullivan referenced this pull request Jun 16, 2023
….1.0 (#156766) (#157111)

# Backport

This will backport the following commits from `main` to `7.17`:
- [[Reporting/Screenshotting] upgrade Puppeteer dependency to v20.1.0
(#156766)](#156766)

Depends on #157436

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tim
Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-08T21:11:27Z","message":"[Reporting/Screenshotting]
upgrade Puppeteer dependency to v20.1.0 (#156766)\n\n##
Summary\r\n\r\nUpgrades the dependency for capturing screenshots with
Chromium
to\r\n[Puppeteer\r\nv20.1.0](https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-v20.1.0)\r\n\r\nWe're
using publicly available Chromium downloads for Windows and Mac.\r\nFor
Linux, we create a custom build that doesn't have dependencies on\r\nX11
shared libraries.\r\n\r\n**Versions:**\r\n* Linux:
**113.0.5672.63**\r\n* Windows: **113.0.5672.0**\r\n* Darwin x64:
**113.0.5672.0**\r\n* Darwin arm64: **113.0.5672.0**\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Verified in
Cloud deployment\r\n\r\n### For maintainers\r\n\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"89a8ab858eab8a7c46b89ea57fd5b18c68d28d6a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:SharedUX","ci:cloud-deploy","ci:cloud-redeploy","v8.6.3","v8.7.2","v8.9.0","v7.17.11","v8.8.1"],"number":156766,"url":"https://github.com/elastic/kibana/pull/156766","mergeCommit":{"message":"[Reporting/Screenshotting]
upgrade Puppeteer dependency to v20.1.0 (#156766)\n\n##
Summary\r\n\r\nUpgrades the dependency for capturing screenshots with
Chromium
to\r\n[Puppeteer\r\nv20.1.0](https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-v20.1.0)\r\n\r\nWe're
using publicly available Chromium downloads for Windows and Mac.\r\nFor
Linux, we create a custom build that doesn't have dependencies on\r\nX11
shared libraries.\r\n\r\n**Versions:**\r\n* Linux:
**113.0.5672.63**\r\n* Windows: **113.0.5672.0**\r\n* Darwin x64:
**113.0.5672.0**\r\n* Darwin arm64: **113.0.5672.0**\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Verified in
Cloud deployment\r\n\r\n### For maintainers\r\n\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"89a8ab858eab8a7c46b89ea57fd5b18c68d28d6a"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","7.17"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/157091","number":157091,"state":"OPEN"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156766","number":156766,"mergeCommit":{"message":"[Reporting/Screenshotting]
upgrade Puppeteer dependency to v20.1.0 (#156766)\n\n##
Summary\r\n\r\nUpgrades the dependency for capturing screenshots with
Chromium
to\r\n[Puppeteer\r\nv20.1.0](https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-v20.1.0)\r\n\r\nWe're
using publicly available Chromium downloads for Windows and Mac.\r\nFor
Linux, we create a custom build that doesn't have dependencies on\r\nX11
shared libraries.\r\n\r\n**Versions:**\r\n* Linux:
**113.0.5672.63**\r\n* Windows: **113.0.5672.0**\r\n* Darwin x64:
**113.0.5672.0**\r\n* Darwin arm64: **113.0.5672.0**\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Verified in
Cloud deployment\r\n\r\n### For maintainers\r\n\r\n- [x] This was
checked for breaking API changes and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"89a8ab858eab8a7c46b89ea57fd5b18c68d28d6a"}},{"branch":"7.17","label":"v7.17.11","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/157088","number":157088,"state":"OPEN"}]}]
BACKPORT-->

---------

Co-authored-by: Kibana Machine <[email protected]>
@tsullivan tsullivan deleted the backport/8.7/pr-156766 branch November 21, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants