[7.17] [Reporting/Screenshotting] upgrade Puppeteer dependency to v20.1.0 (#156766) #157111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…lastic#156766) ## Summary Upgrades the dependency for capturing screenshots with Chromium to [Puppeteer v20.1.0](https://github.com/puppeteer/puppeteer/releases/tag/puppeteer-v20.1.0) We're using publicly available Chromium downloads for Windows and Mac. For Linux, we create a custom build that doesn't have dependencies on X11 shared libraries. **Versions:** * Linux: **113.0.5672.63** * Windows: **113.0.5672.0** * Darwin x64: **113.0.5672.0** * Darwin arm64: **113.0.5672.0** ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Verified in Cloud deployment ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> # Conflicts: # package.json # src/dev/build/tasks/install_chromium.ts # src/dev/chromium_version/index.ts # src/dev/tsconfig.json # x-pack/build_chromium/linux/args.gn # x-pack/plugins/reporting/server/browsers/chromium/driver_factory/args.ts # x-pack/plugins/reporting/server/browsers/chromium/paths.ts # x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/args.test.ts # x-pack/plugins/screenshotting/server/browsers/chromium/driver_factory/index.ts # x-pack/plugins/screenshotting/server/browsers/download/index.ts # x-pack/plugins/screenshotting/server/browsers/install.ts # x-pack/plugins/screenshotting/tsconfig.json # yarn.lock
tsullivan
force-pushed
the
backport/7.17/pr-156766
branch
from
8104719 to
861aca4
Compare
Ikuni17
added a commit
that referenced
this pull request
Jun 9, 2023
Closes #157436 Unblocks: #157111 # Backport This will backport the following commits from `main` to `7.17`: - [Upgrade to Jest 29 (#143319)](#143319) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jonathan Budzenski","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-18T15:40:16Z","message":"Upgrade to Jest 29 (#143319)\n\nhttps://jestjs.io/blog/2022/04/25/jest-28\r\nhttps://jestjs.io/blog/2022/08/25/jest-29\r\n\r\n- jest.useFakeTimers('legacy') -> jest.useFakeTimers({ legacyFakeTimers:\r\ntrue });\r\n- jest.useFakeTimers('modern'); -> jest.useFakeTimers();\r\n- tests can either use promises or callbacks, but not both\r\n- test runner jasmine is no longer included, switch all suites to\r\njest-circus\r\n\r\nCo-authored-by: Andrew Tate <[email protected]>","sha":"2ac7ebe3bf9bd3a8e18c71df5f7c51541ecec339","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Feature:Embedding","Team:APM","Feature:ExpressionLanguage","Team:uptime","release_note:skip","backport:skip","Team:Fleet","v8.7.0"],"number":143319,"url":"https://github.com/elastic/kibana/pull/143319","mergeCommit":{"message":"Upgrade to Jest 29 (#143319)\n\nhttps://jestjs.io/blog/2022/04/25/jest-28\r\nhttps://jestjs.io/blog/2022/08/25/jest-29\r\n\r\n- jest.useFakeTimers('legacy') -> jest.useFakeTimers({ legacyFakeTimers:\r\ntrue });\r\n- jest.useFakeTimers('modern'); -> jest.useFakeTimers();\r\n- tests can either use promises or callbacks, but not both\r\n- test runner jasmine is no longer included, switch all suites to\r\njest-circus\r\n\r\nCo-authored-by: Andrew Tate <[email protected]>","sha":"2ac7ebe3bf9bd3a8e18c71df5f7c51541ecec339"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/143319","number":143319,"mergeCommit":{"message":"Upgrade to Jest 29 (#143319)\n\nhttps://jestjs.io/blog/2022/04/25/jest-28\r\nhttps://jestjs.io/blog/2022/08/25/jest-29\r\n\r\n- jest.useFakeTimers('legacy') -> jest.useFakeTimers({ legacyFakeTimers:\r\ntrue });\r\n- jest.useFakeTimers('modern'); -> jest.useFakeTimers();\r\n- tests can either use promises or callbacks, but not both\r\n- test runner jasmine is no longer included, switch all suites to\r\njest-circus\r\n\r\nCo-authored-by: Andrew Tate <[email protected]>","sha":"2ac7ebe3bf9bd3a8e18c71df5f7c51541ecec339"}}]}] BACKPORT--> --------- Co-authored-by: Tiago Costa <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
|
@elasticmachine merge upstream |
|
@tsullivan maybe you need to backport something else to make those last failing tests to pass. The jest backport is done on 7.17 branch |
|
Looking into this now. |
tsullivan
added
ci:cloud-deploy
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
legrego
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:Depends on #157436
Questions ?
Please refer to the Backport tool documentation