Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] refresh data on visualization scrubbing #156777

Merged
merged 3 commits into from
May 5, 2023
Merged

[Synthetics] refresh data on visualization scrubbing #156777

merged 3 commits into from
May 5, 2023

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented May 5, 2023 •
edited by kibanamachine
Loading

Summary

Resolves #156776

Refreshes data when visualization scrubbing occurs.

This also has the nice benefit of refreshing data when the monitor is changed, or the location is changed, which I think is a nice touch.

Synthetics-Monitor-History-Synthetics---Kibana.1.webm

Testing

  1. Create a monitor and wait for some data to fill in
  2. Scrub a visualization on the history or errors page
  3. Notice the page updates

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v8.8.0 v8.9.0 labels May 5, 2023
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner May 5, 2023 02:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke changed the title [Synthetics] - refresh data on visualization scrubbing [Synthetics] refresh data on visualization scrubbing May 5, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +35.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@shahzad31 shahzad31 merged commit 29fe83f into elastic:main May 5, 2023
@shahzad31 shahzad31 deleted the fix/refresh-app-on-visualization-scrubbing branch May 5, 2023 08:21
@kibanamachine kibanamachine mentioned this pull request May 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 5, 2023
@dominiqueclarke
[Synthetics] refresh data on visualization scrubbing (elastic#156777)
dc7bcdb 
Co-authored-by: Shahzad <[email protected]>
(cherry picked from commit 29fe83f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit that referenced this pull request May 5, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
630343b 
* main: (153 commits)
  [Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
  [Synthetics] refresh data on visualization scrubbing (#156777)
  [RAM] Docs for slack improvements (#153885)
  [RAM] Alert search bar only KQL (#155947)
  [ML] Functional tests - stabilize export job tests (#156586)
  [Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
  [ML] Rename `curated` model type to `elastic` (#156684)
  [Discover] Enable sharing for text based languages (#156652)
  [api-docs] 2023-05-05 Daily api_docs build (#156781)
  Upgrade EUI to v77.2.2 (#155208)
  [RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
  [DOCS] Case file attachments (#156459)
  [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
  [Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
  [Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
  [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
  [Logs onboarding] StepsFooter outside of main panel (#156686)
  [Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
  [Enterprise Search][Behavioral Analytics] Update formulas (#156704)
  Add API Events to Endpoint Security Advanced Policy (#156718)
  ...
kibanamachine added a commit that referenced this pull request May 5, 2023
@kibanamachine @dominiqueclarke
[8.8] [Synthetics] refresh data on visualization scrubbing (#156777) (#…
592fc0d 
…156799)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Synthetics] refresh data on visualization scrubbing
(#156777)](#156777)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-05T08:21:42Z","message":"[Synthetics]
refresh data on visualization scrubbing (#156777)\n\nCo-authored-by:
Shahzad
<[email protected]>","sha":"29fe83f06a34f092a4533700e5ebaba1fca4dc80","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:uptime","release_note:skip","v8.8.0","v8.9.0"],"number":156777,"url":"https://github.com/elastic/kibana/pull/156777","mergeCommit":{"message":"[Synthetics]
refresh data on visualization scrubbing (#156777)\n\nCo-authored-by:
Shahzad
<[email protected]>","sha":"29fe83f06a34f092a4533700e5ebaba1fca4dc80"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156777","number":156777,"mergeCommit":{"message":"[Synthetics]
refresh data on visualization scrubbing (#156777)\n\nCo-authored-by:
Shahzad
<[email protected]>","sha":"29fe83f06a34f092a4533700e5ebaba1fca4dc80"}}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <[email protected]>
@dominiqueclarke dominiqueclarke mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
6 participants
@dominiqueclarke @elasticmachine @apmmachine @kibana-ci @kibanamachine @shahzad31