Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Rename curated model type to elastic #156684

Merged
merged 2 commits into from
May 5, 2023
Merged

[ML] Rename curated model type to elastic #156684

merged 2 commits into from
May 5, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented May 4, 2023 •
edited by kibanamachine
Loading

Summary

Rename the curated model type and tag to elastic

@darnautov darnautov added :ml Team:ML Team label for ML (also use :ml) v8.8.0 v8.9.0 labels May 4, 2023
@darnautov darnautov requested a review from peteharverson May 4, 2023 13:16
@darnautov darnautov self-assigned this May 4, 2023
@darnautov darnautov requested a review from a team as a code owner May 4, 2023 13:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov added the release_note:skip Skip the PR/issue when compiling release notes label May 4, 2023
@droberts195
Copy link
Contributor

The only question I have is how this will look in the period while the model metadata on GCS contains a different tag to what's now in the code. Does this make the model invisible? Or just a missing tag? People are trying to do QA so I just want to make sure the UI isn't unusable during the changeover period.

@darnautov
Copy link
Contributor Author

The only question I have is how this will look in the period while the model metadata on GCS contains a different tag to what's now in the code. Does this make the model invisible? Or just a missing tag? People are trying to do QA so I just want to make sure the UI isn't unusable during the changeover period.

@droberts195 the model is still visible, just type elastic won't be present in the table after downloading until the tag from the metadata isn't updated to elastic.

Before downloading:
image

After downloading:
image

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #9 / InfraOps App feature controls infrastructure security global infrastructure all privileges infrastructure landing page with data shows Wafflemap

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB -99.0B
ml 3.4MB 3.4MB -89.0B
total -188.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

droberts195
droberts195 approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov requested a review from jgowdyelastic May 4, 2023 15:34
jgowdyelastic
jgowdyelastic approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov merged commit 3f42de3 into elastic:main May 5, 2023
@darnautov darnautov deleted the ml-rename-curated-tag branch May 5, 2023 06:57
@kibanamachine kibanamachine mentioned this pull request May 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 5, 2023
@darnautov
[ML] Rename curated model type to elastic (elastic#156684)
e66bf74 
## Summary

Rename the `curated` model type and tag to `elastic`

(cherry picked from commit 3f42de3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 5, 2023
@kibanamachine @darnautov
[8.8] [ML] Rename curated model type to elastic (#156684) (#156786)
0d6161a 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[ML] Rename `curated` model type to `elastic`
(#156684)](#156684)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-05-05T06:57:50Z","message":"[ML]
Rename `curated` model type to `elastic` (#156684)\n\n##
Summary\r\n\r\nRename the `curated` model type and tag to
`elastic`","sha":"3f42de3f5f571a79b8a5d464230b02be03eb4763","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Team:ML","v8.8.0","v8.9.0"],"number":156684,"url":"https://github.com/elastic/kibana/pull/156684","mergeCommit":{"message":"[ML]
Rename `curated` model type to `elastic` (#156684)\n\n##
Summary\r\n\r\nRename the `curated` model type and tag to
`elastic`","sha":"3f42de3f5f571a79b8a5d464230b02be03eb4763"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156684","number":156684,"mergeCommit":{"message":"[ML]
Rename `curated` model type to `elastic` (#156684)\n\n##
Summary\r\n\r\nRename the `curated` model type and tag to
`elastic`","sha":"3f42de3f5f571a79b8a5d464230b02be03eb4763"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
jloleysens added a commit that referenced this pull request May 5, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
630343b 
* main: (153 commits)
  [Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
  [Synthetics] refresh data on visualization scrubbing (#156777)
  [RAM] Docs for slack improvements (#153885)
  [RAM] Alert search bar only KQL (#155947)
  [ML] Functional tests - stabilize export job tests (#156586)
  [Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
  [ML] Rename `curated` model type to `elastic` (#156684)
  [Discover] Enable sharing for text based languages (#156652)
  [api-docs] 2023-05-05 Daily api_docs build (#156781)
  Upgrade EUI to v77.2.2 (#155208)
  [RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
  [DOCS] Case file attachments (#156459)
  [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
  [Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
  [Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
  [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
  [Logs onboarding] StepsFooter outside of main panel (#156686)
  [Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
  [Enterprise Search][Behavioral Analytics] Update formulas (#156704)
  Add API Events to Endpoint Security Advanced Policy (#156718)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@droberts195 droberts195 droberts195 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.8.0 v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darnautov @elasticmachine @droberts195 @kibana-ci @kibanamachine @jgowdyelastic