Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Fix next / prev test navigation #155624

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Apr 24, 2023

Summary

Fixes #155539

Fixed next and previous checkgroup/test run navigation on

  • Monitor test run details page
  • Test run step details page

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review April 24, 2023 16:16
@shahzad31 shahzad31 requested a review from a team as a code owner April 24, 2023 16:16
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.2MB 1.2MB +4.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 395 398 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 475 478 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working as expected on both the step run details page and the monitor details page.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 merged commit 4e4f408 into elastic:main Apr 25, 2023
@shahzad31 shahzad31 deleted the fix-source-nav branch April 25, 2023 06:11
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 25, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 25, 2023
# Backport

This will backport the following commits from `main` to `8.7`:
- [[Synthetics] Fix next / prev test navigation
(#155624)](#155624)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-25T06:11:19Z","message":"[Synthetics]
Fix next / prev test navigation
(#155624)","sha":"4e4f408a34f418053d5433eec8d59250816b0ba8","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:uptime","v8.8.0","v8.7.2"],"number":155624,"url":"https://github.com/elastic/kibana/pull/155624","mergeCommit":{"message":"[Synthetics]
Fix next / prev test navigation
(#155624)","sha":"4e4f408a34f418053d5433eec8d59250816b0ba8"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155624","number":155624,"mergeCommit":{"message":"[Synthetics]
Fix next / prev test navigation
(#155624)","sha":"4e4f408a34f418053d5433eec8d59250816b0ba8"}},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.7.1 v8.7.2 v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Previous Check link doesn’t work
6 participants