Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix json validation and empty json handling in advanced settings #15531

Merged
merged 1 commit into from
Dec 15, 2017
Merged

fix json validation and empty json handling in advanced settings #15531

merged 1 commit into from
Dec 15, 2017

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Dec 11, 2017

close #12921

@elasticmachine
Copy link
Contributor

Can one of the admins verify this patch?

@thomasneirynck
Copy link
Contributor

jenkins, test this

nreese
nreese approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks for the contribution

@nreese nreese requested a review from chrisronline December 15, 2017 20:03
chrisronline
chrisronline approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the contribution! LGTM!

@chrisronline chrisronline merged commit bb09492 into elastic:master Dec 15, 2017
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Dec 15, 2017
@scampi @chrisronline
fix json validation and empty json handling in advanced settings (ela…
6d0baed 
…stic#15531)
@chrisronline chrisronline mentioned this pull request Dec 15, 2017
Merged
@scampi scampi deleted the issue12921-json-input-error branch December 17, 2017 10:30
chrisronline added a commit that referenced this pull request Dec 18, 2017
@chrisronline
fix json validation and empty json handling in advanced settings (#15531
7173053 
) (#15644)
@chrisronline
Copy link
Contributor

Backport

6.x: 7173053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees
No one assigned
Labels
v6.2.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced settings JSON input error
5 participants
@scampi @elasticmachine @thomasneirynck @chrisronline @nreese