Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced settings JSON input error #12921

Closed
lukasolson opened this issue Jul 17, 2017 · 0 comments · Fixed by #15531
Closed

Advanced settings JSON input error #12921

lukasolson opened this issue Jul 17, 2017 · 0 comments · Fixed by #15531
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit PR sent

Comments

@lukasolson
Copy link
Member

  1. Go to advanced settings
  2. For any of the JSON inputs, try emptying out the input then saving

You won't see an error in the UI. It will look like it's trying to save. If you look at the developer console, you'll see the following:

angular.js:12477 SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at getCurrentValue (config.js:175)
    at Object.config.get (config.js:33)
    at advertise (config.js:151)
    at localUpdate (config.js:130)
    at change (config.js:118)
    at Object.config.set (config.js:36)
    at advanced_row.js:60
    at loading (advanced_row.js:36)
    at Scope.$scope.save (advanced_row.js:55)

I'd expect either of the following instead:

  1. The save button is disabled until you enter valid JSON (this is what happens when you type something that isn't valid JSON into the input), or
  2. The save is successful and just saves with an empty JSON object.

jul-17-2017 12-04-46

@lukasolson lukasolson added :Management bug Fixes for quality problems that affect the customer experience labels Jul 17, 2017
@chrisronline chrisronline added the good first issue low hanging fruit label Nov 8, 2017
@nreese nreese added the PR sent label Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit PR sent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants