Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Surface new overview dashboards in fleet #154914

Merged
merged 8 commits into from
Apr 18, 2023

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Apr 13, 2023

Closes #153848

Summary

  • Adds two link buttons on top of agent list page to access "Ingest overview" and "Agent Info" dashboards

Screenshot 2023-04-13 at 15 22 53

The links are built using the new URL service locator and the getRedirectLink method;

  • Refactoring existing instances of useKibanaLink to use the url locator instead;

These new dashboards were already accessible from the elastic_agent.* datastreams table actions, however I replaced the useKibanaLink hook there as well:

Screenshot 2023-04-13 at 16 03 47

TODO: I don't know where to add the "Integrations" dashboard yet, I'm not sure it should go on the Integrations details page.

Checklist

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico self-assigned this Apr 13, 2023
@criamico criamico changed the title 153848 dashboard links [Fleet] Surface new overview dashboards in fleet Apr 13, 2023
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0 labels Apr 13, 2023
@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico criamico marked this pull request as ready for review April 17, 2023 09:16
@criamico criamico requested a review from a team as a code owner April 17, 2023 09:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@criamico criamico added the release_note:skip Skip the PR/issue when compiling release notes label Apr 17, 2023
@nchaulet nchaulet requested review from nchaulet and removed request for nchaulet April 17, 2023 14:10
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Can we test that the dashboard really exists in the current space? or at least check the elastic agent is installed?

@criamico
Copy link
Contributor Author

criamico commented Apr 17, 2023

@nchaulet I think that checking that the elastic agent is installed might be enough - edit: i committed a1c6d4a where the dashboards links are displayed only when totalAgents > 0

@criamico criamico requested a review from kpollich April 17, 2023 14:55
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 796 798 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 993 994 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 943.6KB 944.6KB +1.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 126.2KB 126.7KB +525.0B
Unknown metric groups

API count

id before after diff
fleet 1098 1099 +1

ESLint disabled line counts

id before after diff
fleet 51 49 -2
securitySolution 432 435 +3
total +1

Total ESLint disabled count

id before after diff
fleet 61 59 -2
securitySolution 512 515 +3
total +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@criamico criamico merged commit 970de91 into elastic:main Apr 18, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 18, 2023
@jen-huang jen-huang added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 18, 2023
@rsdrakh
Copy link

rsdrakh commented May 25, 2023

Yeah my deployment cannot find the dashboards... :-)

@ebeahan
Copy link
Member

ebeahan commented Jul 12, 2023

I think that checking that the elastic agent is installed might be enough

Not sure what the experience is like for self-managed, but on cloud, Fleet server registers as an agent so the links to these dashboards appear. Clicking either returns a 404 in Kibana.

Screenshot 2023-07-12 at 5 15 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Help users find integration health dashboards
10 participants