[Fleet] Dashboards links in agent list page are broken in cloud #161827
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Fleet
Team label for Observability Data Collection Fleet team
Comments
criamico
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
|
I ran into this issue when running an older version of the Elastic Agent Integration (v1.5). After upgrading the Elastic Agent Integration to v1.8 the buttons worked perfectly. One thing that made it a bit difficult to resolve was that the Elastic Agent Integration did not show up in the list of my installed integrations so I had to manually search for it in the general integrations page to push the upgrade to 1.8 |
|
We still have this issue on-prem in Elastic-Stack 8.8.2. Using multiple Kibana Spaces doesn't seem to work with this feature. The assets are installed (Dashboards). When clicking on the buttons we get the error Error: The integrations seem to be inconsistent sometime and especially when failing to upgrade the integration gets removed from installed and needs to be searched under the general integration page. |
6 tasks
hop-dev
added a commit
that referenced
this issue
Aug 23, 2023
…-server agent and if the dashboards exist (#164469) ## Summary Closes #161827 These buttons were showing in cloud when there was only the cloud agent added: <img width="647" alt="Screenshot 2023-08-22 at 16 18 51" src="https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15"> The ingest dashboard links will now only show if: - the user has one agent that is not part of a policy containing fleet server (I have re-used an existing hook we have to check this here) - the agent ingest metrics dashaboard exists in the current space Test Scenarios 1. Setup fleet with ONLY a fleet server connected, the dashboard links should not show 2. Setup fleet with fleet server and another non-fleet server agent, the dashboard links should show 3. With the same setup as test case 2, now create another space, visit fleet in the new space, the links should not show as the dashboards are not installed in the current space. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Aug 23, 2023
…-server agent and if the dashboards exist (elastic#164469) ## Summary Closes elastic#161827 These buttons were showing in cloud when there was only the cloud agent added: <img width="647" alt="Screenshot 2023-08-22 at 16 18 51" src="https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15"> The ingest dashboard links will now only show if: - the user has one agent that is not part of a policy containing fleet server (I have re-used an existing hook we have to check this here) - the agent ingest metrics dashaboard exists in the current space Test Scenarios 1. Setup fleet with ONLY a fleet server connected, the dashboard links should not show 2. Setup fleet with fleet server and another non-fleet server agent, the dashboard links should show 3. With the same setup as test case 2, now create another space, visit fleet in the new space, the links should not show as the dashboards are not installed in the current space. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 805c974)
kibanamachine
added a commit
that referenced
this issue
Aug 23, 2023
…one non-server agent and if the dashboards exist (#164469) (#164539) # Backport This will backport the following commits from `main` to `8.10`: - [[Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (#164469)](#164469) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-23T08:53:49Z","message":"[Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (#164469)\n\n## Summary\r\n\r\nCloses #161827\r\n\r\nThese buttons were showing in cloud when there was only the cloud agent\r\nadded:\r\n\r\n<img width=\"647\" alt=\"Screenshot 2023-08-22 at 16 18 51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15\">\r\n\r\nThe ingest dashboard links will now only show if:\r\n\r\n- the user has one agent that is not part of a policy containing fleet\r\nserver (I have re-used an existing hook we have to check this here)\r\n- the agent ingest metrics dashaboard exists in the current space\r\n\r\nTest Scenarios\r\n\r\n1. Setup fleet with ONLY a fleet server connected, the dashboard links\r\nshould not show\r\n2. Setup fleet with fleet server and another non-fleet server agent, the\r\ndashboard links should show\r\n3. With the same setup as test case 2, now create another space, visit\r\nfleet in the new space, the links should not show as the dashboards are\r\nnot installed in the current space.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"805c974ed0c6f30be9153734859e0a28fa95eae1","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.11.0"],"number":164469,"url":"https://github.com/elastic/kibana/pull/164469","mergeCommit":{"message":"[Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (#164469)\n\n## Summary\r\n\r\nCloses #161827\r\n\r\nThese buttons were showing in cloud when there was only the cloud agent\r\nadded:\r\n\r\n<img width=\"647\" alt=\"Screenshot 2023-08-22 at 16 18 51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15\">\r\n\r\nThe ingest dashboard links will now only show if:\r\n\r\n- the user has one agent that is not part of a policy containing fleet\r\nserver (I have re-used an existing hook we have to check this here)\r\n- the agent ingest metrics dashaboard exists in the current space\r\n\r\nTest Scenarios\r\n\r\n1. Setup fleet with ONLY a fleet server connected, the dashboard links\r\nshould not show\r\n2. Setup fleet with fleet server and another non-fleet server agent, the\r\ndashboard links should show\r\n3. With the same setup as test case 2, now create another space, visit\r\nfleet in the new space, the links should not show as the dashboards are\r\nnot installed in the current space.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"805c974ed0c6f30be9153734859e0a28fa95eae1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164469","number":164469,"mergeCommit":{"message":"[Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (#164469)\n\n## Summary\r\n\r\nCloses #161827\r\n\r\nThese buttons were showing in cloud when there was only the cloud agent\r\nadded:\r\n\r\n<img width=\"647\" alt=\"Screenshot 2023-08-22 at 16 18 51\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/baaff9b9-17fc-49b5-bad9-980f91a5ae15\">\r\n\r\nThe ingest dashboard links will now only show if:\r\n\r\n- the user has one agent that is not part of a policy containing fleet\r\nserver (I have re-used an existing hook we have to check this here)\r\n- the agent ingest metrics dashaboard exists in the current space\r\n\r\nTest Scenarios\r\n\r\n1. Setup fleet with ONLY a fleet server connected, the dashboard links\r\nshould not show\r\n2. Setup fleet with fleet server and another non-fleet server agent, the\r\ndashboard links should show\r\n3. With the same setup as test case 2, now create another space, visit\r\nfleet in the new space, the links should not show as the dashboards are\r\nnot installed in the current space.\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"805c974ed0c6f30be9153734859e0a28fa95eae1"}}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #154914
When on cloud the links for
Ingest overview MetricsandAgent Info Metrics dashboardsare shown even though there is still no agent. This results in a 404 when clicking the link.The reason is the Elastic Cloud Agent policy registers an agent ( see comment), so the condition of having some agents to show the dashboard is not enough to avoid broken links.
The text was updated successfully, but these errors were encountered: