Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip tests after ES promotion fixes #154863

Merged

Conversation

kevinlog
Copy link
Contributor

Summary

Resolves #154740 #154741

These tests were skipped due to an ES promotion block. This PR: elastic/elasticsearch#95187 was added on the ES side and another snapshot was promoted which should allow us to un skip these tests.

Checklist

@kevinlog kevinlog added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0 labels Apr 12, 2023
@kevinlog kevinlog requested a review from a team as a code owner April 12, 2023 18:40
@kevinlog kevinlog requested review from pzl and dasansol92 April 12, 2023 18:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

green for me if the tests are!

@kevinlog
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kevinlog kevinlog merged commit 935a16d into elastic:main Apr 12, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 12, 2023
@kevinlog kevinlog deleted the task/unskip-tests-after-es-promotion-fix branch April 12, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing ES Promotion: FTR Configs #3 / Endpoint plugin
5 participants