Skip to content

Commit

Permalink
[Security Solution] Unskip tests after ES promotion fixes (#154863)
Browse files Browse the repository at this point in the history
## Summary

Resolves #154740
#154741

These tests were skipped due to an ES promotion block. This PR:
elastic/elasticsearch#95187 was added on the ES
side and another snapshot was promoted which should allow us to un skip
these tests.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
kevinlog and kibanamachine authored Apr 12, 2023
1 parent 49b763f commit 935a16d
Show file tree
Hide file tree
Showing 12 changed files with 18 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const visitPolicyDetailsPage = () => {
cy.get('#settings').should('exist'); // waiting for Policy Settings tab
};

describe.skip('Artifact tabs in Policy Details page', () => {
describe('Artifact tabs in Policy Details page', () => {
before(() => {
login();
loadEndpointDataForEventFiltersIfNeeded();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const loginWithoutAccess = (url: string) => {
cy.visit(url);
};

describe.skip('Artifacts pages', () => {
describe('Artifacts pages', () => {
before(() => {
login();
loadEndpointDataForEventFiltersIfNeeded();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import { closeAllToasts } from '../../tasks/close_all_toasts';
import { login } from '../../tasks/login';

describe.skip('When defining a kibana role for Endpoint security access', () => {
describe('When defining a kibana role for Endpoint security access', () => {
const getAllSubFeatureRows = (): Cypress.Chainable<JQuery<HTMLElement>> => {
return cy
.get('#featurePrivilegeControls_siem')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import { login } from '../../tasks/login';
import { runEndpointLoaderScript } from '../../tasks/run_endpoint_loader';

describe.skip('Endpoints page', () => {
describe('Endpoints page', () => {
before(() => {
runEndpointLoaderScript();
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { indexNewCase } from '../../tasks/index_new_case';
import { indexEndpointHosts } from '../../tasks/index_endpoint_hosts';
import { indexEndpointRuleAlerts } from '../../tasks/index_endpoint_rule_alerts';

describe.skip('When accessing Endpoint Response Console', () => {
describe('When accessing Endpoint Response Console', () => {
const performResponderSanityChecks = () => {
openResponderActionLogFlyout();
// Ensure the popover in the action log date quick select picker is accessible
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { cleanupRule, generateRandomStringName, loadRule } from '../../tasks/api
import { RESPONSE_ACTION_TYPES } from '../../../../../common/detection_engine/rule_response_actions/schemas';
import { loginWithRole, ROLE } from '../../tasks/login';

describe.skip('Response actions', () => {
describe('Response actions', () => {
describe('User with no access can not create an endpoint response action', () => {
before(() => {
loginWithRole(ROLE.endpoint_response_actions_no_access);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ import {
export default function (providerContext: FtrProviderContext) {
const { loadTestFile, getService } = providerContext;

// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/154741
describe.skip('endpoint', function () {
describe('endpoint', function () {
const ingestManager = getService('ingestManager');
const log = getService('log');
const endpointTestResources = getService('endpointTestResources');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function ({ getService }: FtrProviderContext) {
const endpointPolicyTestResources = getService('endpointPolicyTestResources');
const endpointArtifactTestResources = getService('endpointArtifactTestResources');

describe.skip('Endpoint artifacts (via lists plugin): Blocklists', () => {
describe('Endpoint artifacts (via lists plugin): Blocklists', () => {
let fleetEndpointPolicy: PolicyTestResourceInfo;

before(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default function ({ getService }: FtrProviderContext) {
const endpointPolicyTestResources = getService('endpointPolicyTestResources');
const endpointArtifactTestResources = getService('endpointArtifactTestResources');

describe.skip('Endpoint artifacts (via lists plugin): Event Filters', () => {
describe('Endpoint artifacts (via lists plugin): Event Filters', () => {
let fleetEndpointPolicy: PolicyTestResourceInfo;

before(async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default function ({ getService }: FtrProviderContext) {
const endpointPolicyTestResources = getService('endpointPolicyTestResources');
const endpointArtifactTestResources = getService('endpointArtifactTestResources');

describe.skip('Endpoint Host Isolation Exceptions artifacts (via lists plugin)', () => {
describe('Endpoint Host Isolation Exceptions artifacts (via lists plugin)', () => {
let fleetEndpointPolicy: PolicyTestResourceInfo;
let hostIsolationExceptionData: ArtifactTestData;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function ({ getService }: FtrProviderContext) {
const endpointPolicyTestResources = getService('endpointPolicyTestResources');
const endpointArtifactTestResources = getService('endpointArtifactTestResources');

describe.skip('Endpoint artifacts (via lists plugin): Trusted Applications', () => {
describe('Endpoint artifacts (via lists plugin): Trusted Applications', () => {
let fleetEndpointPolicy: PolicyTestResourceInfo;

before(async () => {
Expand Down
19 changes: 7 additions & 12 deletions x-pack/test/security_solution_endpoint_api_int/apis/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,20 +43,15 @@ export default function endpointAPIIntegrationTests(providerContext: FtrProvider
});

loadTestFile(require.resolve('./resolver'));
// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/154740
// loadTestFile(require.resolve('./metadata'));
loadTestFile(require.resolve('./metadata'));
loadTestFile(require.resolve('./policy'));
loadTestFile(require.resolve('./package'));
// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/154740
// loadTestFile(require.resolve('./endpoint_authz'));
// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/154740
// loadTestFile(require.resolve('./endpoint_response_actions/execute'));
loadTestFile(require.resolve('./endpoint_authz'));
loadTestFile(require.resolve('./endpoint_response_actions/execute'));
loadTestFile(require.resolve('./file_upload_index'));
// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/154740
// loadTestFile(require.resolve('./endpoint_artifacts/trusted_apps'));
// loadTestFile(require.resolve('./endpoint_artifacts/event_filters'));
// loadTestFile(require.resolve('./endpoint_artifacts/host_isolation_exceptions'));
// loadTestFile(require.resolve('./endpoint_artifacts/blocklists'));
//
loadTestFile(require.resolve('./endpoint_artifacts/trusted_apps'));
loadTestFile(require.resolve('./endpoint_artifacts/event_filters'));
loadTestFile(require.resolve('./endpoint_artifacts/host_isolation_exceptions'));
loadTestFile(require.resolve('./endpoint_artifacts/blocklists'));
});
}

0 comments on commit 935a16d

Please sign in to comment.