[ZDT] Implement ModelVersion polling mechanism
#154329
Conversation
jloleysens
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
jloleysens
changed the title
ModelVersion polling mechanism
|
|
||
| const POLL_INTERVAL_MS = 30_000; | ||
| /** TODO: Is this the correct pattern? In this way we will also be matching indices after "the split" */ | ||
| const KIBANA_SYSTEM_INDICES_PATTERN = '.kibana_*'; |
There was a problem hiding this comment.
We could match on a one-of or entries from a collection of patterns. EIther a map or, to keep it simple, an array of patterns.
| }); | ||
| } catch (e) { | ||
| if ( | ||
| e instanceof errors.ResponseError && |
There was a problem hiding this comment.
What's the risk of an intermittent proxy response? Should we also be checking the headers?
| * (1) Run a request against Elasticsearch for Kibana system indices. For a | ||
| * class of bad responses will retry up to 5 times with backoff. | ||
| * (2) Build a model version map and emit this value | ||
| * (3) Wait for `pollInterval` ms before repeating the process. |
There was a problem hiding this comment.
Do we poll indefinitely and, if so, is that to address the concern around potential rollbacks?
The original issue suggests only polling until "the index version matches the app version".
💔 Build FailedFailed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @jloleysens |
| return await client.indices.getMapping({ | ||
| index: KIBANA_SYSTEM_INDICES_PATTERN, | ||
| expand_wildcards: 'hidden', | ||
| }); |
There was a problem hiding this comment.
I'd use filter_path to only fetch the _meta
|
Since we are no longer doing this for MVP, we should probably close this |
|
No longer needed. |
Summary
Close #152809.
To reviewers
Observableand a "get current" function