Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOR: implement polling to retrieve the current model version #152809

Closed
pgayvallet opened this issue Mar 7, 2023 · 2 comments
Closed

SOR: implement polling to retrieve the current model version #152809

pgayvallet opened this issue Mar 7, 2023 · 2 comments
Assignees
Labels
Epic:ZDTmigrations Zero downtime migrations Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

pgayvallet commented Mar 7, 2023

Part of #150312

Depends on #152219

In managed mode, the SOR will have to retrieve the informations about the current model version from the index's meta to know which version it should convert to for writes.

The scope of this issue is only to implement the polling mechanism, not to use it

Technically, we need the polling to be performed only once (one actor) for all of the instantiated repositories. So we will probably want to introduce the concept of SavedObjectModelStatusProvider (or any better name) that will be shared between all the repositories (and probably created/managed by the top level service)

questions

  • are we safe to stop polling once the index version matches the app version ? what about rollbacks ?
@pgayvallet pgayvallet added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Mar 7, 2023
@pgayvallet pgayvallet added the Epic:ZDTmigrations Zero downtime migrations label Mar 7, 2023
@rudolf rudolf changed the title SOR: implement pooling to retrieve the current model version SOR: implement pulling to retrieve the current model version Mar 7, 2023
@rudolf rudolf changed the title SOR: implement pulling to retrieve the current model version SOR: implement polling to retrieve the current model version Mar 7, 2023
@jloleysens jloleysens self-assigned this Apr 3, 2023
@pgayvallet
Copy link
Contributor Author

This is not going to be necessary for the MVP.

Keeping the issue open though, as it may come back later.

@rayafratkina
Copy link
Contributor

Closing for now - we will recreate or reopen if/when needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic:ZDTmigrations Zero downtime migrations Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants