Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Watcher] Remove deprecated savedObjectsClient #154172

Merged

Conversation

yuliacech
Copy link
Contributor

@yuliacech yuliacech commented Mar 31, 2023

Summary

Fixes #154035

This PR removes the saved objects client from the client-side code of the Watcher plugin. It seems not to be used anywhere so the removal should not cause any changes to the UI.
To test this PR, it should be enough to create/update/delete a couple of simple and advanced watches.

@yuliacech yuliacech added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Watcher release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Mar 31, 2023
@yuliacech yuliacech marked this pull request as ready for review April 6, 2023 09:49
@yuliacech yuliacech requested a review from a team as a code owner April 6, 2023 09:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
watcher 273.6KB 273.6KB -33.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
watcher 13.5KB 13.4KB -37.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

References to deprecated APIs

id before after diff
watcher 8 2 -6

Total ESLint disabled count

id before after diff
securitySolution 513 516 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching this up @yuliacech! Changes lgtm, tested locally 🚀

@yuliacech yuliacech merged commit 7daa791 into elastic:main Apr 11, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 11, 2023
@yuliacech yuliacech deleted the 8.8/watcher/remove-saved-objects-client branch February 15, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Watcher release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Watcher] Remove unused SavedObjectsClientContract
5 participants