Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Watcher] Remove unused SavedObjectsClientContract #154035

Closed
yuliacech opened this issue Mar 30, 2023 · 1 comment · Fixed by #154172
Closed

[Watcher] Remove unused SavedObjectsClientContract #154035

yuliacech opened this issue Mar 30, 2023 · 1 comment · Fixed by #154172
Assignees
@yuliacech
Labels
Feature:Watcher Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

yuliacech commented Mar 30, 2023 •
edited
Loading

There is an import of the deprecated SavedObjectsClientContract in the client side code of the Watcher plugin here. It doesn't seem to be used anywhere in the Watcher code later so I think we should be able to remove it without any complications.
The SavedObjectsClientContract will be removed in the near future, see this issue for more details.
This work is needed in preparation for versioned HTTP APIs.
@yuliacech yuliacech added Feature:Watcher Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Mar 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@yuliacech yuliacech self-assigned this Mar 31, 2023
@yuliacech yuliacech mentioned this issue Mar 31, 2023
Merged
yuliacech added a commit that referenced this issue Apr 11, 2023
@yuliacech
[Watcher] Remove deprecated savedObjectsClient (#154172)
7daa791 
## Summary
Fixes #154035

This PR removes the saved objects client from the client-side code of
the Watcher plugin. It seems not to be used anywhere so the removal
should not cause any changes to the UI.
To test this PR, it should be enough to create/update/delete a couple of
simple and advanced watches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuliacech yuliacech

Labels
Feature:Watcher Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Watcher] Remove deprecated savedObjectsClient yuliacech/kibana
2 participants
@yuliacech @elasticmachine