-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps][Window Maintenance] Add window maintenance to alerting plugin public folder and add create form #153445
[ResponseOps][Window Maintenance] Add window maintenance to alerting plugin public folder and add create form #153445
Conversation
…nance_windows_create_form
…:doakalexi/kibana into alerting/maintenance_windows_create_form
…:doakalexi/kibana into alerting/maintenance_windows_create_form
…:doakalexi/kibana into alerting/maintenance_windows_create_form
…:doakalexi/kibana into alerting/maintenance_windows_create_form
…:doakalexi/kibana into alerting/maintenance_windows_create_form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI text LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…:doakalexi/kibana into alerting/maintenance_windows_create_form
x-pack/plugins/alerting/public/application/maintenance_windows.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/components/form.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/components/form.tsx
Outdated
Show resolved
Hide resolved
...gins/alerting/public/pages/maintenance_windows/components/fields/date_picker_range_field.tsx
Outdated
Show resolved
Hide resolved
...gins/alerting/public/pages/maintenance_windows/components/fields/date_picker_range_field.tsx
Outdated
Show resolved
Hide resolved
...c/pages/maintenance_windows/components/recurring_schedule_form/custom_recurring_schedule.tsx
Outdated
Show resolved
Hide resolved
...c/pages/maintenance_windows/components/recurring_schedule_form/custom_recurring_schedule.tsx
Outdated
Show resolved
Hide resolved
...c/pages/maintenance_windows/components/recurring_schedule_form/custom_recurring_schedule.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/components/schema.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/components/schema.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few last comments, but otherwise LGTM!
x-pack/plugins/alerting/public/pages/maintenance_windows/helpers/convert_to_rrule.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/helpers/convert_to_rrule.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/helpers/get_weekday_info.test.ts
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/helpers/get_nth_by_weekday.test.ts
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/helpers/recurring_summary.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/helpers/recurring_summary.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/alerting/public/pages/maintenance_windows/helpers/convert_to_rrule.ts
Outdated
Show resolved
Hide resolved
…:doakalexi/kibana into alerting/maintenance_windows_create_form
…:doakalexi/kibana into alerting/maintenance_windows_create_form
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Resolves #152272
Summary
Checklist
To verify
ENABLE_MAINTENANCE_WINDOWS = true
tox-pack/plugins/alerting/common/index.ts
Create a maintenance window
button and verify it takes you to the create fromname
andduration
fields