Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Window Maintenance] Add window maintenance to alerting plugin public folder and add create form #153445

Merged

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Mar 22, 2023

Resolves #152272

Summary

  • This PR adds maintenance windows to the alerting plugin and also adds the create form.
  • The Maintenance Windows feature is hidden by a feature flag by default.
  • The create form calls the create api, but it's expected to fail because the api hasn't been merged.

Screen Shot 2023-04-03 at 2 56 45 PM

Screen Shot 2023-04-03 at 2 56 56 PM

Screen Shot 2023-04-03 at 2 57 12 PM

Checklist

To verify

  • Enable maintenance windows by adding ENABLE_MAINTENANCE_WINDOWS = true to x-pack/plugins/alerting/common/index.ts
  • Go to http://localhost:5601/app/management/insightsAndAlerting/maintenanceWindows or select the Maintenance Windows link on the side nav
  • Click the Create a maintenance window button and verify it takes you to the create from
  • Verify the bread crumbs and the return link work correctly
  • Once on the create form, try to submit without entering any values and verify that the form doesn't submit and errors are shown on the name and duration fields
  • Submit a maintenance window that is not recurring. You'll see an error popup but verify that the request body is correct and matches what you've selected in the form.
  • Create a maintenance window that is recurring and try choosing the different options on the recurring form. Verify that the summary at the bottom of the form accurately reflects what you have selected.
  • Submit a maintenance window that is recurring. Again, you'll see an error popup but verify that the request body is correct and matches what you've selected in the form.

@doakalexi doakalexi changed the title Alerting/maintenance windows create form [ResponseOps][Window Maintenance] Add window maintenance to alerting plugin public folder and add create form Mar 23, 2023
@doakalexi doakalexi added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes v8.8.0 labels Mar 23, 2023
@doakalexi doakalexi marked this pull request as ready for review March 24, 2023 19:11
@doakalexi doakalexi requested review from a team as code owners March 24, 2023 19:11
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI text LGTM, thanks!

@lcawl lcawl mentioned this pull request Apr 3, 2023
31 tasks
Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few last comments, but otherwise LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
alerting 35 78 +43

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 550 551 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alerting 0.0B 152.3KB +152.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
alerting 44.6KB 47.9KB +3.4KB
Unknown metric groups

API count

id before after diff
alerting 571 572 +1

async chunk count

id before after diff
alerting 0 4 +4

ESLint disabled in files

id before after diff
alerting 1 2 +1

ESLint disabled line counts

id before after diff
alerting 80 82 +2
securitySolution 433 436 +3
total +5

Total ESLint disabled count

id before after diff
alerting 81 84 +3
securitySolution 512 515 +3
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi merged commit 752147e into elastic:main Apr 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 13, 2023
@lcawl lcawl mentioned this pull request May 23, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ResponseOps][Window Maintenance] Add window maintenance to alerting plugin public folder and add create form
9 participants