Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Window Maintenance] Add window maintenance to alerting plugin public folder and add create form #152272

Closed
doakalexi opened this issue Feb 27, 2023 · 1 comment · Fixed by #153445
Assignees
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@doakalexi
Copy link
Contributor

Meta issue: #152032

@doakalexi doakalexi added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Feb 27, 2023
@doakalexi doakalexi self-assigned this Feb 27, 2023
@doakalexi doakalexi moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Feb 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@doakalexi doakalexi changed the title [ResponseOps][Window Maintenance] Add window maintenance to the alerting plugin and add the create form [ResponseOps][Window Maintenance] Add window maintenance public folder to alerting plugin and add the create form Feb 27, 2023
@doakalexi doakalexi changed the title [ResponseOps][Window Maintenance] Add window maintenance public folder to alerting plugin and add the create form [ResponseOps][Window Maintenance] Add window maintenance to alerting plugin public folder and add create form Feb 27, 2023
@doakalexi doakalexi moved this from Todo to In Progress in AppEx: ResponseOps - Execution & Connectors Feb 27, 2023
@doakalexi doakalexi moved this from In Progress to In Review in AppEx: ResponseOps - Execution & Connectors Mar 24, 2023
doakalexi added a commit that referenced this issue Apr 13, 2023
…plugin public folder and add create form (#153445)

Resolves #152272

## Summary

- This PR adds maintenance windows to the alerting plugin and also adds
the create form.
- The Maintenance Windows feature is hidden by a feature flag by
default.
- The create form calls the create api, but it's expected to fail
because the api hasn't been merged.

<img width="1709" alt="Screen Shot 2023-04-03 at 2 56 45 PM"
src="https://user-images.githubusercontent.com/109488926/229601948-13a46847-bebc-4674-9446-55163a6a6589.png">

<img width="1706" alt="Screen Shot 2023-04-03 at 2 56 56 PM"
src="https://user-images.githubusercontent.com/109488926/229601997-03b232cf-0d50-4047-a92b-79ef0c1e9568.png">

<img width="1706" alt="Screen Shot 2023-04-03 at 2 57 12 PM"
src="https://user-images.githubusercontent.com/109488926/229602015-7e0110e6-dd3d-41c4-8601-64943fe01323.png">


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios


### To verify
- Enable maintenance windows by adding `ENABLE_MAINTENANCE_WINDOWS =
true` to `x-pack/plugins/alerting/common/index.ts`
- Go to
http://localhost:5601/app/management/insightsAndAlerting/maintenanceWindows
or select the Maintenance Windows link on the side nav
- Click the `Create a maintenance window` button and verify it takes you
to the create from
- Verify the bread crumbs and the return link work correctly
- Once on the create form, try to submit without entering any values and
verify that the form doesn't submit and errors are shown on the `name`
and `duration` fields
- Submit a maintenance window that is not recurring. You'll see an error
popup but verify that the request body is correct and matches what
you've selected in the form.
- Create a maintenance window that is recurring and try choosing the
different options on the recurring form. Verify that the summary at the
bottom of the form accurately reflects what you have selected.
- Submit a maintenance window that is recurring. Again, you'll see an
error popup but verify that the request body is correct and matches what
you've selected in the form.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
2 participants