Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.7] [Fleet] Fix missing scrolling bar in categories column (#153181) #153183

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.7:

Questions ?

Please refer to the Backport tool documentation

Closes elastic#149378

## Summary
Fixing missing scrolling bar in Integrations `categories` left column. I
replaced the `sticky` css property with the class `kbnStickyMenu`
defined
[here](https://github.com/elastic/kibana/blob/3c7bf5840539fad8e45e6d490bb7a82b955ba9f5/src/core/public/styles/rendering/_base.scss#L47-L51).
This class is applied above a certain breakpoint.

### Large viewport
The categories column is sticky:

https://user-images.githubusercontent.com/16084106/224733525-362d6b0c-321a-476d-ae5f-caad45ef3fcc.mov

### Smaller viewport
The categories column now has a scrolling bar:

https://user-images.githubusercontent.com/16084106/224733690-b310fb78-1ee3-45a7-bc45-dd29ffdc280b.mov
(cherry picked from commit bb3f917)
@kibanamachine kibanamachine enabled auto-merge (squash) March 13, 2023 16:07
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine kibanamachine merged commit bebe420 into elastic:8.7 Mar 13, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 930.0KB 930.0KB +9.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants