[Fleet] Fix missing scrolling bar in categories column #153181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criamico
added
v8.8.0
backport:prev-minor
criamico
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @criamico |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 13, 2023
Closes elastic#149378 ## Summary Fixing missing scrolling bar in Integrations `categories` left column. I replaced the `sticky` css property with the class `kbnStickyMenu` defined [here](https://github.com/elastic/kibana/blob/3c7bf5840539fad8e45e6d490bb7a82b955ba9f5/src/core/public/styles/rendering/_base.scss#L47-L51). This class is applied above a certain breakpoint. ### Large viewport The categories column is sticky: https://user-images.githubusercontent.com/16084106/224733525-362d6b0c-321a-476d-ae5f-caad45ef3fcc.mov ### Smaller viewport The categories column now has a scrolling bar: https://user-images.githubusercontent.com/16084106/224733690-b310fb78-1ee3-45a7-bc45-dd29ffdc280b.mov (cherry picked from commit bb3f917)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 13, 2023
#153183) # Backport This will backport the following commits from `main` to `8.7`: - [[Fleet] Fix missing scrolling bar in categories column (#153181)](#153181) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cristina Amico","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-13T16:00:33Z","message":"[Fleet] Fix missing scrolling bar in categories column (#153181)\n\nCloses https://github.com/elastic/kibana/issues/149378\r\n\r\n## Summary\r\nFixing missing scrolling bar in Integrations `categories` left column. I\r\nreplaced the `sticky` css property with the class `kbnStickyMenu`\r\ndefined\r\n[here](https://github.com/elastic/kibana/blob/3c7bf5840539fad8e45e6d490bb7a82b955ba9f5/src/core/public/styles/rendering/_base.scss#L47-L51).\r\nThis class is applied above a certain breakpoint.\r\n\r\n### Large viewport\r\nThe categories column is sticky:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733525-362d6b0c-321a-476d-ae5f-caad45ef3fcc.mov\r\n\r\n### Smaller viewport\r\nThe categories column now has a scrolling bar:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733690-b310fb78-1ee3-45a7-bc45-dd29ffdc280b.mov","sha":"bb3f91715e2780238b02e69e80cca83534ee6eff","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.8.0"],"number":153181,"url":"https://github.com/elastic/kibana/pull/153181","mergeCommit":{"message":"[Fleet] Fix missing scrolling bar in categories column (#153181)\n\nCloses https://github.com/elastic/kibana/issues/149378\r\n\r\n## Summary\r\nFixing missing scrolling bar in Integrations `categories` left column. I\r\nreplaced the `sticky` css property with the class `kbnStickyMenu`\r\ndefined\r\n[here](https://github.com/elastic/kibana/blob/3c7bf5840539fad8e45e6d490bb7a82b955ba9f5/src/core/public/styles/rendering/_base.scss#L47-L51).\r\nThis class is applied above a certain breakpoint.\r\n\r\n### Large viewport\r\nThe categories column is sticky:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733525-362d6b0c-321a-476d-ae5f-caad45ef3fcc.mov\r\n\r\n### Smaller viewport\r\nThe categories column now has a scrolling bar:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733690-b310fb78-1ee3-45a7-bc45-dd29ffdc280b.mov","sha":"bb3f91715e2780238b02e69e80cca83534ee6eff"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153181","number":153181,"mergeCommit":{"message":"[Fleet] Fix missing scrolling bar in categories column (#153181)\n\nCloses https://github.com/elastic/kibana/issues/149378\r\n\r\n## Summary\r\nFixing missing scrolling bar in Integrations `categories` left column. I\r\nreplaced the `sticky` css property with the class `kbnStickyMenu`\r\ndefined\r\n[here](https://github.com/elastic/kibana/blob/3c7bf5840539fad8e45e6d490bb7a82b955ba9f5/src/core/public/styles/rendering/_base.scss#L47-L51).\r\nThis class is applied above a certain breakpoint.\r\n\r\n### Large viewport\r\nThe categories column is sticky:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733525-362d6b0c-321a-476d-ae5f-caad45ef3fcc.mov\r\n\r\n### Smaller viewport\r\nThe categories column now has a scrolling bar:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/16084106/224733690-b310fb78-1ee3-45a7-bc45-dd29ffdc280b.mov","sha":"bb3f91715e2780238b02e69e80cca83534ee6eff"}}]}] BACKPORT--> Co-authored-by: Cristina Amico <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149378
Summary
Fixing missing scrolling bar in Integrations
categoriesleft column. I replaced thestickycss property with the classkbnStickyMenudefined here. This class is applied above a certain breakpoint.Large viewport
The categories column is sticky:
Screen.Recording.2023-03-13.at.15.28.36.mov
Smaller viewport
The categories column now has a scrolling bar:
Screen.Recording.2023-03-13.at.15.27.38.mov