Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Exceptions]- Increase exceptions test coverage #152757

Merged
merged 69 commits into from
Jun 7, 2023

Conversation

WafaaNasr
Copy link
Contributor

@WafaaNasr WafaaNasr commented Mar 6, 2023

Summary

  • Addresses https://github.com/elastic/security-team/issues/5947
  • Adding tests to cover the yellow rows in test sheet
  • Organise the tests to correspond to the following structure
  • Removed the x-pack/plugins/security_solution/cypress/e2e/exceptions/alerts_table_flow/add_exception.cy.ts as it was duplicated from x-pack/plugins/security_solution/cypress/e2e/exceptions/exceptions_management_flow/exceptions_table.cy.ts
  • Skipped the flyout_validation tests until resolving this ticket
  • Regarding Exception-List, Exception-List-Item and Rule with exceptions migrations test cases are handled by most of our old FTR tests as most of them deal with Exception List Schema which doesn't include the new props, like the expire_time that was introduced in 8.7, so adding new tests using the new schema can be treated as testing the new versions against the existing scenarios whereas the existing tests for the migrations (downgrade) tests 4a75a51
  • Tests under x-pack/plugins/security_solution/cypress/upgrade_e2e are just POCs can't be used

New tests folder structure based on workflow

image

@WafaaNasr WafaaNasr marked this pull request as ready for review March 7, 2023 17:57
@WafaaNasr WafaaNasr requested review from a team as code owners March 7, 2023 17:57
@WafaaNasr WafaaNasr self-assigned this Mar 7, 2023
@WafaaNasr WafaaNasr added release_note:skip Skip the PR/issue when compiling release notes Feature:Visual Testing Team:Security Solution Platform Security Solution Platform Team labels Mar 7, 2023
@WafaaNasr WafaaNasr added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.7.0 labels Mar 8, 2023
@WafaaNasr WafaaNasr requested a review from a team as a code owner March 8, 2023 17:10
@WafaaNasr WafaaNasr requested a review from a team as a code owner May 31, 2023 14:01
@WafaaNasr WafaaNasr requested a review from a team as a code owner June 2, 2023 12:11
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of thanks for helping improving the test coverage!!

To minimize the risk of flakiness in a future, would be nice to load the default auditbeat archive in the after hook where we use the reset kibana method.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #1 / Isolate command from Manage "before all" hook for "should allow filtering endpoint by Isolated status"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.8MB 10.8MB +215.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 413 417 +4
total +6

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 497 501 +4
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @WafaaNasr

@WafaaNasr WafaaNasr merged commit 0051086 into elastic:main Jun 7, 2023
@WafaaNasr WafaaNasr deleted the increase-exceptions-test-coverage branch June 7, 2023 14:15
@kibanamachine kibanamachine added v8.9.0 backport:skip This commit does not require backporting labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Functional Testing Feature:Visual Testing release_note:skip Skip the PR/issue when compiling release notes Team:Security Solution Platform Security Solution Platform Team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants