-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Exceptions]- Increase exceptions test coverage #152757
[Security Solution][Exceptions]- Increase exceptions test coverage #152757
Conversation
…e-exceptions-test-coverage
…e-exceptions-test-coverage
…e-exceptions-test-coverage
…e-exceptions-test-coverage
...e/exceptions/shared_exception_lists_management/shared_exception_list_page/import_lists.cy.ts
Outdated
Show resolved
Hide resolved
…e-exceptions-test-coverage
…e-exceptions-test-coverage
…e-exceptions-test-coverage
…e-exceptions-test-coverage
…e-exceptions-test-coverage
x-pack/plugins/lists/common/schemas/request/import_exceptions_schema.mock.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/cypress/e2e/exceptions/entry/comments.cy.ts
Show resolved
Hide resolved
…e-exceptions-test-coverage
…context for migration tests of the exception list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of thanks for helping improving the test coverage!!
To minimize the risk of flakiness in a future, would be nice to load the default auditbeat archive in the after hook where we use the reset kibana method.
…e-exceptions-test-coverage
…e-exceptions-test-coverage
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
Summary
x-pack/plugins/security_solution/cypress/e2e/exceptions/alerts_table_flow/add_exception.cy.ts
as it was duplicated fromx-pack/plugins/security_solution/cypress/e2e/exceptions/exceptions_management_flow/exceptions_table.cy.ts
flyout_validation
tests until resolving this ticketException-List
,Exception-List-Item
andRule with exceptions
migrations test cases are handled by most of our oldFTR
tests as most of them deal withException List Schema
which doesn't include the new props, like theexpire_time
that was introduced in8.7
, so adding new tests using the new schema can be treated as testing the new versions against the existing scenarios whereas the existing tests for the migrations (downgrade) tests 4a75a51x-pack/plugins/security_solution/cypress/upgrade_e2e
are just POCs can't be usedNew tests folder structure based on workflow