-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner #151869
[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner #151869
Conversation
…he No results match your search criteria banner. (elastic#151262)
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @e40pud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
…he No results match your search criteria banner (elastic#151869) ## Summary Issue elastic#151262 These changes fixes broken empty preview results state on smaller screens. Bug: <img width="1117" alt="Screenshot 2023-02-22 at 15 24 06" src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png"> Fix: <img width="1117" alt="Screenshot 2023-02-22 at 15 23 25" src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png"> (cherry picked from commit 1f21d36)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…laps the No results match your search criteria banner (#151869) (#152728) # Backport This will backport the following commits from `main` to `8.7`: - [[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner (#151869)](#151869) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-06T15:28:04Z","message":"[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue #151262\r\n\r\nThese changes fixes broken empty preview results state on smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 24 06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23 25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Alerts","backport:prev-minor","v8.8.0"],"number":151869,"url":"https://github.com/elastic/kibana/pull/151869","mergeCommit":{"message":"[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue #151262\r\n\r\nThese changes fixes broken empty preview results state on smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 24 06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23 25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151869","number":151869,"mergeCommit":{"message":"[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue #151262\r\n\r\nThese changes fixes broken empty preview results state on smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 24 06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23 25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5"}}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
…he No results match your search criteria banner (elastic#151869) ## Summary Issue elastic#151262 These changes fixes broken empty preview results state on smaller screens. Bug: <img width="1117" alt="Screenshot 2023-02-22 at 15 24 06" src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png"> Fix: <img width="1117" alt="Screenshot 2023-02-22 at 15 23 25" src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png">
Summary
Issue #151262
These changes fixes broken empty preview results state on smaller screens.
Bug:
Fix: