Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Rule preview when returns zero value it overlaps the No results match your search criteria banner. #151262

Closed
sukhwindersingh-qasource opened this issue Feb 15, 2023 · 8 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0

Comments

@sukhwindersingh-qasource

Describe the bug:
Rule preview when returns zero value it overlaps the No results match your search criteria banner.

Build Details:

VERSION: 8.7.0
BUILD: 60614
COMMIT: d3b239d76aa04f073836f6100782134ac86887e2

Preconditions

  • Kibana should be running.

Steps to Reproduce

  • Navigate to Security
  • Now navigate to rules tab
  • Click on create a new rule.
  • Under custom query add query as : process.name
  • Now click on refresh button under rule preview.

Actual Result
Rule preview when returns zero value it overlaps the No results match your search criteria banner.

Expected Result
Rule preview when returns zero value then No results match your search criteria banner should not be overlapped.

Screen-shot
rule preview

Screen-Recording

Create.new.rule.-.Kibana.-.Google.Chrome.2023-02-15.15-17-41.mp4
@sukhwindersingh-qasource sukhwindersingh-qasource added bug Fixes for quality problems that affect the customer experience triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Feb 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@sukhwindersingh-qasource
Copy link
Author

Kindly review this @karanbirsingh-qasource .

@MadameSheema
Copy link
Member

@sukhwindersingh-qasource may you please share your screen resolution? Thanks!!

I'm able to reproduce it on my 16-inch laptop (1728x1117) but is working fine on my external screen (2560x1440).

@MadameSheema MadameSheema assigned marshallmain and unassigned ghost Feb 15, 2023
@MadameSheema MadameSheema added Team:Detections and Resp Security Detection Response Team Team:Detection Alerts Security Detection Alerts Area Team labels Feb 15, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@sukhwindersingh-qasource
Copy link
Author

Hi @MadameSheema
Screen resolution of my screen is : 1920 x 1080.
Kindly let us know if anything else is required from our end.
Thanks!!

@marshallmain marshallmain assigned e40pud and unassigned marshallmain Feb 16, 2023
e40pud added a commit to e40pud/kibana that referenced this issue Feb 22, 2023
e40pud added a commit that referenced this issue Mar 6, 2023
…he No results match your search criteria banner (#151869)

## Summary

Issue #151262

These changes fixes broken empty preview results state on smaller
screens.

Bug:

<img width="1117" alt="Screenshot 2023-02-22 at 15 24 06"
src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png">

Fix:

<img width="1117" alt="Screenshot 2023-02-22 at 15 23 25"
src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 6, 2023
…he No results match your search criteria banner (elastic#151869)

## Summary

Issue elastic#151262

These changes fixes broken empty preview results state on smaller
screens.

Bug:

<img width="1117" alt="Screenshot 2023-02-22 at 15 24 06"
src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png">

Fix:

<img width="1117" alt="Screenshot 2023-02-22 at 15 23 25"
src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png">

(cherry picked from commit 1f21d36)
kibanamachine added a commit that referenced this issue Mar 6, 2023
…laps the No results match your search criteria banner (#151869) (#152728)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution]Rule preview when returns zero value it overlaps
the No results match your search criteria banner
(#151869)](#151869)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-06T15:28:04Z","message":"[Security
Solution]Rule preview when returns zero value it overlaps the No results
match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue
#151262\r\n\r\nThese changes fixes broken empty preview results state on
smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\"
alt=\"Screenshot 2023-02-22 at 15 24
06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img
width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23
25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections
and Resp","Team: SecuritySolution","Team:Detection
Alerts","backport:prev-minor","v8.8.0"],"number":151869,"url":"https://github.com/elastic/kibana/pull/151869","mergeCommit":{"message":"[Security
Solution]Rule preview when returns zero value it overlaps the No results
match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue
#151262\r\n\r\nThese changes fixes broken empty preview results state on
smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\"
alt=\"Screenshot 2023-02-22 at 15 24
06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img
width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23
25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151869","number":151869,"mergeCommit":{"message":"[Security
Solution]Rule preview when returns zero value it overlaps the No results
match your search criteria banner (#151869)\n\n## Summary\r\n\r\nIssue
#151262\r\n\r\nThese changes fixes broken empty preview results state on
smaller\r\nscreens.\r\n\r\nBug:\r\n\r\n<img width=\"1117\"
alt=\"Screenshot 2023-02-22 at 15 24
06\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png\">\r\n\r\nFix:\r\n\r\n<img
width=\"1117\" alt=\"Screenshot 2023-02-22 at 15 23
25\"\r\nsrc=\"https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png\">","sha":"1f21d36593f72cd518ad6850609a202d3fdf7ec5"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <[email protected]>
@e40pud e40pud added the fixed label Mar 6, 2023
@e40pud
Copy link
Contributor

e40pud commented Mar 6, 2023

@sukhwindersingh-qasource @MadameSheema This bug was fixed and changes were merged into main and 8.7 branches.

@MadameSheema
Copy link
Member

Thanks @e40pud!!

Pending to be validated on BC5.

@sukhwindersingh-qasource
Copy link
Author

Hi @MadameSheema
We have validated this issue on 8.7.0 BC5 build and observed that issue looks like , It is Fixed. ✔️

Please find the below Testing Details:

Build info

VERSION: 8.7.0
BUILD: 61017
COMMIT: e70452f9697a18a8458f3d4618e001b7e3681bed

Screen-Recording

Create.new.rule.-.Kibana.Mozilla.Firefox.2023-03-10.11-48-09.mp4

Hence We are closing this ticket and marking it as QA Validated
Thanks!!

@sukhwindersingh-qasource sukhwindersingh-qasource added the QA:Validated Issue has been validated by QA label Mar 10, 2023
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
…he No results match your search criteria banner (elastic#151869)

## Summary

Issue elastic#151262

These changes fixes broken empty preview results state on smaller
screens.

Bug:

<img width="1117" alt="Screenshot 2023-02-22 at 15 24 06"
src="https://user-images.githubusercontent.com/2700761/220650014-dff19a56-637a-4c25-aa43-174eea2c91a1.png">

Fix:

<img width="1117" alt="Screenshot 2023-02-22 at 15 23 25"
src="https://user-images.githubusercontent.com/2700761/220650063-33cf4382-d8c8-4b30-acc3-62427094f09a.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Alerts Security Detection Alerts Area Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0
Projects
None yet
Development

No branches or pull requests

5 participants