[Fleet] Fix add fleet server flow from agent policy page #149507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
|
@nchaulet I tested locally and I'm seeing some flickering in the flyout when clicking on "add agent": Flickering.movI remember having this issue when I was working on the flyout last year, it probably depends on the order which the flags are evaluated. |
…o fix-add-fleet-server
|
@criamico I just pushed a fix for the flickering case let me know if it's working for you |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 26, 2023
) (cherry picked from commit da83d96)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 26, 2023
…) (#149605) # Backport This will backport the following commits from `main` to `8.6`: - [[Fleet] Fix add fleet server flow from agent policy page (#149507)](#149507) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-26T15:55:36Z","message":"[Fleet] Fix add fleet server flow from agent policy page (#149507)","sha":"da83d96ff65a3ad5f56d350576e6c4811e5f26af","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.7.0","v8.6.1"],"number":149507,"url":"https://github.com/elastic/kibana/pull/149507","mergeCommit":{"message":"[Fleet] Fix add fleet server flow from agent policy page (#149507)","sha":"da83d96ff65a3ad5f56d350576e6c4811e5f26af"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/149507","number":149507,"mergeCommit":{"message":"[Fleet] Fix add fleet server flow from agent policy page (#149507)","sha":"da83d96ff65a3ad5f56d350576e6c4811e5f26af"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #143519
Fix the add Fleet server flow from the agent policy flow
UI Changes
On click on
Add Fleet ServerBefore
After