Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Self-Managed][Fleet]: User is navigated to Add agent flyout on clicking Add agent button from Fleet Server policy. #143519

Closed
amolnater-qasource opened this issue Oct 18, 2022 · 11 comments · Fixed by #144105, #148686 or #149507
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.6.1

Comments

@amolnater-qasource
Copy link

Kibana version: 8.5 BC6 Kibana self-managed environment

Host OS: Windows

Build details:
VERSION: 8.5 BC6 Kibana self-managed environment
BUILD: 57022
COMMIT: 0b06c14

Preconditions:

  1. 8.5.0 Self-managed kibana cloud environment should be available.
  2. Fleet Server should be installed.

Steps to reproduce:

  1. Create a fleet server policy.
  2. Navigate to Agent policy>Fleet Server policy.
  3. Click Actions>Add agent and observe Add agent flyout is visible.

Expected Result:
User should be navigated to Add fleet-server flyout on clicking Add agent button from Fleet Server policy.

Screen Recording:

ec2-3-92-32-90.-.ec2-3-92-32-90.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2022-10-18.14-52-38.mp4
@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@hop-dev hop-dev self-assigned this Oct 18, 2022
@hop-dev
Copy link
Contributor

hop-dev commented Oct 19, 2022

This isn't a regression in 8.5 looks like this was the behaviour in 8.4 as well (so maybe that changes the priority?)

The fleet server flyout guides the user to make a fleet server policy, but as in the video above the user already has one. So I don't think this is a straightforward bug fix @kpollich

@hop-dev hop-dev removed their assignment Oct 19, 2022
@kpollich
Copy link
Member

@hop-dev - I think the fix here is to not open the Add an Agent flyout initially when the user selects Add Agent from the actions dropdown on a Fleet Server policy. The "add a Fleet Server" flow should be opened directly.

@amolnater-qasource does that sound correct to you?

@dikshachauhan-qasource
Copy link

Hi @kpollich

Yes, this is the expected result we are seeking for.

Thanks
QAS

@nchaulet
Copy link
Member

nchaulet commented Oct 25, 2022

The fleet server flyout guides the user to make a fleet server policy, but as in the video above the user already has one. So I don't think this is a straightforward bug fix @kpollich

I guess we could modify a little the Fleet server Flyout, to allow to preselect an agent policy instead of creating a new one, @kpollich @hop-dev if this make sense to you, I can try to get a PR for that.

@amolnater-qasource
Copy link
Author

Hi @nchaulet

We have revalidated this issue on latest 8.6 BC10 Kibana self-managed environment and found it still reproducible.

Observations:

  • User is navigated to Add agent flyout on clicking Add agent button from Fleet Server policy.

Note:

  • No fleet server is installed.

Build details:
BUILD: 58852
COMMIT: d3a625e

Screen Recording:

Amol.Self-Win.-.ec2-54-163-45-96.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2023-01-10.14-10-25.mp4

Hence we are re-opening this issue.
Thanks!

@amolnater-qasource amolnater-qasource removed the QA:Ready for Testing Code is merged and ready for QA to validate label Jan 10, 2023
@nchaulet
Copy link
Member

Looks like we are not handling the case where no fleet server never enrolled, seems an easy one to fix will take a look.

@amolnater-qasource
Copy link
Author

Hi @nchaulet

We have revalidated this issue on latest 8.6.1 BC3 Kibana self-managed environment and had below observations:

Observations:

  • When no agent is installed, Add fleet server option is available under Fleet Server policy.
  • However, on clicking Add fleet server button, Add fleet server flyout is not opened and following text is visible: Before enrolling agents, [set up central management for Elastic Agents](http://localhost:5601/app/fleet/).

As per our understanding under PR: #148686 , fleet server flyout should be opened.

Build details:
BUILD: 58934
COMMIT: 4c24924

Screen Recording:

Amol.Self-Win.-.ec2-3-90-105-192.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2023-01-25.11-40-11.mp4

Hence we are reopening this issue.
Thanks!

@amolnater-qasource amolnater-qasource added the QA:Ready for Testing Code is merged and ready for QA to validate label Jan 27, 2023
@amolnater-qasource
Copy link
Author

Hi Team,
We have revalidated this issue on latest 8.7.0 BC3 self-managed environment and found it fixed now.

Observations:

  • User is navigated to Add fleet-server flyout on clicking Add agent button from Fleet Server policy.

Build details:
BUILD: 60783
COMMIT: 4ed6814

Screen Recording:

Amol.Self-Win.-.ec2-54-234-45-173.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2023-02-20.10-44-02.mp4

Hence we are marking this issue as QA:Validated.

Thanks

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team v8.6.1
Projects
None yet
7 participants