Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Enables multiple values filtering on tooltip actions #148372

Merged
merged 40 commits into from
Jan 25, 2023

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 4, 2023

Summary

Enables tooltip actions on:

  • Lens embeddables (as soon as the unified search bar exists)
  • Lens
  • Agg based (as they share the same renderer with Lens)

I am not enabling this in TSVB.

lens

Also the action is not enabled for Lens if:

  • there are only series with metrics

Checklist

: undefined
}
actions={
!args.detailedTooltip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I am enabling this only for the EC tooltip and not the custom detailed one (it is only used for agg based)

@stratoula stratoula changed the title [Visualizations] Enable ORs filtering on tooltip actions [Visualizations] Enables multiple values filtering on tooltip actions Jan 9, 2023
@stratoula
Copy link
Contributor Author

Waiting for the #144601 to unblock this.

@stratoula stratoula added Feature:XYAxis XY-Axis charts (bar, area, line) Feature:Lens backport:skip This commit does not require backporting v8.7.0 labels Jan 16, 2023
@stratoula stratoula marked this pull request as ready for review January 16, 2023 11:23
@stratoula stratoula requested review from a team as code owners January 16, 2023 11:23
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! LGTM 👍

src/plugins/data/public/plugin.ts Show resolved Hide resolved
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jan 17, 2023
@stratoula stratoula removed the Feature:Embedding Embedding content via iFrame label Jan 17, 2023
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Jan 17, 2023
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team trigger addition LGTM!

Just out of curiosity, in the example gif in the PR description, why is the resulting filter set up to be an OR, when it might make more sense as an is one of filter, because all of the selections are from the same field?

@stratoula
Copy link
Contributor Author

stratoula commented Jan 19, 2023

@ThomThomson it would be more complicated (indentifying the cases where it would work or not), using only the combined filter can cover all cases (and make our code much simpler). We could do it as a second step of course.

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a code review. Left some minor comments.

Comment on lines 61 to 63
{
id: dataViewId,
} as DataView,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can consider also changing the type signature of buildCombinedFilter to
indexPattern: Pick<DataViewBase, 'id'>, so you don't have to cast to a DataView or to a DataViewBase because the buildCombinedFilter only use the indexPattern id property internally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ab3831e

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 456 458 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
charts 252 255 +3
embeddable 421 427 +6
visualizations 770 771 +1
total +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY 118.6KB 119.7KB +1.1KB
lens 1.3MB 1.3MB +287.0B
unifiedSearch 263.7KB 263.8KB +176.0B
total +1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 406.4KB 407.3KB +969.0B
embeddable 68.7KB 69.2KB +515.0B
expressionXY 37.4KB 37.5KB +60.0B
visualizations 56.7KB 56.7KB +40.0B
total +1.5KB
Unknown metric groups

API count

id before after diff
charts 267 270 +3
embeddable 522 528 +6
visualizations 800 801 +1
total +10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame Feature:Lens Feature:XYAxis XY-Axis charts (bar, area, line) release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants