Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.6] [Security Solution][Exception]: Add to shared lists fixes (#146750) #146887

Merged
merged 2 commits into from
Dec 2, 2022
Merged

[8.6] [Security Solution][Exception]: Add to shared lists fixes (#146750) #146887

merged 2 commits into from
Dec 2, 2022

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.6:

Questions ?

Please refer to the Backport tool documentation

@WafaaNasr
[Security Solution][Exception]: Add to shared lists fixes (#146750)
5fe2744 
## Summary

- Continuing from [PR](#146121) to
apply the same changes to the `Add to Shared Lists`.
- Fix showing the number of Linked rules correctly => in `route.ts` use
the `list.namespaceType` instead of namespaceTypes array
- Apply docs comment on the text
- Use the HeaderMenu item from the `kbn` package for the `Number of
Linked rules` menu
- Allow displaying the HeaderMenu without iconType
- Update snapshots and add tests in HeaderMenu

(cherry picked from commit 78b4851)
@kibanamachine kibanamachine enabled auto-merge (squash) December 2, 2022 14:06
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2022
Merged
@WafaaNasr WafaaNasr disabled auto-merge December 2, 2022 14:57
@WafaaNasr
fix snapshot (#146900)
c9ee673 
fixing snapshot
@WafaaNasr WafaaNasr enabled auto-merge (squash) December 2, 2022 17:46
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #50 / Actions and Triggers app Connectors Opsgenie connector page should disable the run button when the message field is not filled

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3314 3316 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/securitysolution-exception-list-components 91 93 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.7MB 9.9MB +160.5KB
Unknown metric groups

API count

id before after diff
@kbn/securitysolution-exception-list-components 102 104 +2

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @WafaaNasr

@WafaaNasr WafaaNasr merged commit 502fed4 into 8.6 Dec 2, 2022
@WafaaNasr WafaaNasr deleted the backport/8.6/pr-146750 branch December 2, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @WafaaNasr